[PATCH] gpio: max77759: drop use of irqd_get_trigger_type

André Draszik posted 1 patch 1 month, 3 weeks ago
drivers/gpio/gpio-max77759.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
[PATCH] gpio: max77759: drop use of irqd_get_trigger_type
Posted by André Draszik 1 month, 3 weeks ago
irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.

Drop the use from this driver, as it doesn't need to know the trigger
type.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/gpio/gpio-max77759.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-max77759.c b/drivers/gpio/gpio-max77759.c
index 5e48eb03e7b366465e24383a7d1152351906968a..3bf9f23d1532848d8706f7291f59b5c20e9715a4 100644
--- a/drivers/gpio/gpio-max77759.c
+++ b/drivers/gpio/gpio-max77759.c
@@ -435,8 +435,6 @@ static int max77759_gpio_probe(struct platform_device *pdev)
 	int irq;
 	struct gpio_irq_chip *girq;
 	int ret;
-	unsigned long irq_flags;
-	struct irq_data *irqd;
 
 	chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
 	if (!chip)
@@ -486,13 +484,9 @@ static int max77759_gpio_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, ret,
 				     "Failed to add GPIO chip\n");
 
-	irq_flags = IRQF_ONESHOT | IRQF_SHARED;
-	irqd = irq_get_irq_data(irq);
-	if (irqd)
-		irq_flags |= irqd_get_trigger_type(irqd);
-
 	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-					max77759_gpio_irqhandler, irq_flags,
+					max77759_gpio_irqhandler,
+					IRQF_ONESHOT | IRQF_SHARED,
 					dev_name(&pdev->dev), chip);
 	if (ret < 0)
 		return dev_err_probe(&pdev->dev, ret,

---
base-commit: 12b95d29eb979e5c4f4f31bb05817bc935c52050
change-id: 20251217-max77759-gpio-irq-trigger-8e08bfb10b35

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: [PATCH] gpio: max77759: drop use of irqd_get_trigger_type
Posted by Bartosz Golaszewski 1 month, 1 week ago
On Wed, 17 Dec 2025 11:45:06 +0000, André Draszik wrote:
> irqd_get_trigger_type() is meant for cases where the driver needs to
> know the configured IRQ trigger type and e.g. wants to change its
> behaviour accordingly. Furthermore, platform support code, e.g. DT
> handling, will configure the hardware based on that, and drivers don't
> need to pass the trigger type into request_irq() and friends.
> 
> Drop the use from this driver, as it doesn't need to know the trigger
> type.
> 
> [...]

Applied, thanks!

[1/1] gpio: max77759: drop use of irqd_get_trigger_type
      commit: 9d8107579ce4f2369ea3f670585710c30b14a4b4

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>