1. Patchew
  2. linux
  3. View series

[PATCH] stm class: Fix Kconfig symbols

Leo Yan posted 1 patch 1 month, 3 weeks ago
There is a newer version of this series
drivers/hwtracing/stm/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] stm class: Fix Kconfig symbols
Posted by Leo Yan 1 month, 3 weeks ago 
Kconfig symbols must not include the CONFIG_ prefix.  Remove the CONFIG_
prefix for default values to work.

Fixes: a02509f301c6 ("stm class: Factor out default framing protocol")
Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support")
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
 drivers/hwtracing/stm/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..cd7f0b0f3fbebc74775d8835187e49e5bd21d646 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -13,7 +13,7 @@ if STM
 
 config STM_PROTO_BASIC
 	tristate "Basic STM framing protocol driver"
-	default CONFIG_STM
+	default STM
 	help
 	  This is a simple framing protocol for sending data over STM
 	  devices. This was the protocol that the STM framework used
@@ -28,7 +28,7 @@ config STM_PROTO_BASIC
 
 config STM_PROTO_SYS_T
 	tristate "MIPI SyS-T STM framing protocol driver"
-	default CONFIG_STM
+	default STM
 	help
 	  This is an implementation of MIPI SyS-T protocol to be used
 	  over the STP transport. In addition to the data payload, it

---
base-commit: 40fbbd64bba6c6e7a72885d2f59b6a3be9991eeb
change-id: 20251216-fix_stm_kconfig-a72f40c7612c

Best regards,
-- 
Leo Yan <leo.yan@arm.com>
Re: [PATCH] stm class: Fix Kconfig symbols
Posted by James Clark 2 weeks, 6 days ago 

On 17/12/2025 9:39 am, Leo Yan via CoreSight wrote:
> Kconfig symbols must not include the CONFIG_ prefix.  Remove the CONFIG_
> prefix for default values to work.
> 
> Fixes: a02509f301c6 ("stm class: Factor out default framing protocol")
> Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support")
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
>   drivers/hwtracing/stm/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..cd7f0b0f3fbebc74775d8835187e49e5bd21d646 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -13,7 +13,7 @@ if STM
>   
>   config STM_PROTO_BASIC
>   	tristate "Basic STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM
>   	help
>   	  This is a simple framing protocol for sending data over STM
>   	  devices. This was the protocol that the STM framework used
> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
>   
>   config STM_PROTO_SYS_T
>   	tristate "MIPI SyS-T STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM

The help below here says "If you don't know what this is, say N." which 
makes me wonder if this should be on by default or not?

Also everything is in an "if STM" block, so "default STM" is a bit 
redundant. It's not that obvious what the intention was.

James

>   	help
>   	  This is an implementation of MIPI SyS-T protocol to be used
>   	  over the STP transport. In addition to the data payload, it
> 
> ---
> base-commit: 40fbbd64bba6c6e7a72885d2f59b6a3be9991eeb
> change-id: 20251216-fix_stm_kconfig-a72f40c7612c
> 
> Best regards,
Re: [PATCH] stm class: Fix Kconfig symbols
Posted by Leo Yan 2 weeks, 6 days ago 
On Mon, Jan 19, 2026 at 12:35:23PM +0000, James Clark wrote:

[...]

> > @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
> >   config STM_PROTO_SYS_T
> >   	tristate "MIPI SyS-T STM framing protocol driver"
> > -	default CONFIG_STM
> > +	default STM
> 
> The help below here says "If you don't know what this is, say N." which
> makes me wonder if this should be on by default or not?

STM_PROTO_BASIC is a must have config when enabling STM.  While
STM_PROTO_SYS_T is not mandatory, but it is useful to build it so that
users can select the protocol dynamically at runtime.

> Also everything is in an "if STM" block, so "default STM" is a bit
> redundant. It's not that obvious what the intention was.

They are two different things.

"if STM" expresses a dependency (the module depends on STM), while
"default STM" means the module will be selected by default if STM is
enabled.

Thanks,
Leo

P.s. I also tried using the "select" and "imply" syntax to enable the
protocol configurations.  Based on testing, I did not observe any
difference compared to using the "default" syntax.
Re: [PATCH] stm class: Fix Kconfig symbols
Posted by James Clark 2 weeks, 6 days ago 

On 19/01/2026 3:46 pm, Leo Yan wrote:
> On Mon, Jan 19, 2026 at 12:35:23PM +0000, James Clark wrote:
> 
> [...]
> 
>>> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
>>>    config STM_PROTO_SYS_T
>>>    	tristate "MIPI SyS-T STM framing protocol driver"
>>> -	default CONFIG_STM
>>> +	default STM
>>
>> The help below here says "If you don't know what this is, say N." which
>> makes me wonder if this should be on by default or not?
> 
> STM_PROTO_BASIC is a must have config when enabling STM.  While
> STM_PROTO_SYS_T is not mandatory, but it is useful to build it so that
> users can select the protocol dynamically at runtime.
> 

Should probably change that text to say "If you don't know what this is, 
say Y" then? Otherwise it makes the default-on look like a mistake.

>> Also everything is in an "if STM" block, so "default STM" is a bit
>> redundant. It's not that obvious what the intention was.
> 
> They are two different things.
> 
> "if STM" expresses a dependency (the module depends on STM), while
> "default STM" means the module will be selected by default if STM is
> enabled.
> 

Yeah they're the same, it was just a minor nit that "if STM, depends on 
STM" seemed redundant (and obviously more error prone). "default y" 
would also be the same and not repeat the same thing twice. Don't think 
it matters too much either way.

> Thanks,
> Leo
> 
> P.s. I also tried using the "select" and "imply" syntax to enable the
> protocol configurations.  Based on testing, I did not observe any
> difference compared to using the "default" syntax.
Re: [PATCH] stm class: Fix Kconfig symbols
Posted by Leo Yan 2 weeks, 6 days ago 
On Wed, Dec 17, 2025 at 09:39:20AM +0000, Leo Yan wrote:
> Kconfig symbols must not include the CONFIG_ prefix.  Remove the CONFIG_
> prefix for default values to work.

Gentle ping.

> Fixes: a02509f301c6 ("stm class: Factor out default framing protocol")
> Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support")
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
>  drivers/hwtracing/stm/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..cd7f0b0f3fbebc74775d8835187e49e5bd21d646 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -13,7 +13,7 @@ if STM
>  
>  config STM_PROTO_BASIC
>  	tristate "Basic STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM
>  	help
>  	  This is a simple framing protocol for sending data over STM
>  	  devices. This was the protocol that the STM framework used
> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
>  
>  config STM_PROTO_SYS_T
>  	tristate "MIPI SyS-T STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM
>  	help
>  	  This is an implementation of MIPI SyS-T protocol to be used
>  	  over the STP transport. In addition to the data payload, it
> 
> ---
> base-commit: 40fbbd64bba6c6e7a72885d2f59b6a3be9991eeb
> change-id: 20251216-fix_stm_kconfig-a72f40c7612c
> 
> Best regards,
> -- 
> Leo Yan <leo.yan@arm.com>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.