Implement soft_reset, suspend, and resume callbacks using
genphy_soft_reset(), genphy_suspend(), and genphy_resume()
to fix PHY initialization and power management issues.

The soft_reset callback is needed to properly recover the PHY after an
ifconfig down/up cycle. Without it, the PHY can remain in power-down
state, causing MDIO register access failures during config_init().
The soft reset ensures the PHY is operational before configuration.

The suspend/resume callbacks enable proper power management during
system suspend/resume cycles.

Fixes: b2908a989c59 ("net: phy: add driver for MaxLinear MxL86110 PHY")
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
 drivers/net/phy/mxl-86110.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/mxl-86110.c b/drivers/net/phy/mxl-86110.c
index e5d137a37a1d..42a5fe3f115f 100644
--- a/drivers/net/phy/mxl-86110.c
+++ b/drivers/net/phy/mxl-86110.c
@@ -938,6 +938,9 @@ static struct phy_driver mxl_phy_drvs[] = {
 		PHY_ID_MATCH_EXACT(PHY_ID_MXL86110),
 		.name			= "MXL86110 Gigabit Ethernet",
 		.config_init		= mxl86110_config_init,
+		.suspend		= genphy_suspend,
+		.resume			= genphy_resume,
+		.soft_reset		= genphy_soft_reset,
 		.get_wol		= mxl86110_get_wol,
 		.set_wol		= mxl86110_set_wol,
 		.led_brightness_set	= mxl86110_led_brightness_set,
-- 
2.47.3

On 12/16/25 5:25 PM, Stefano Radaelli wrote:
> Implement soft_reset, suspend, and resume callbacks using
> genphy_soft_reset(), genphy_suspend(), and genphy_resume()
> to fix PHY initialization and power management issues.
> 
> The soft_reset callback is needed to properly recover the PHY after an
> ifconfig down/up cycle. Without it, the PHY can remain in power-down
> state, causing MDIO register access failures during config_init().
> The soft reset ensures the PHY is operational before configuration.
> 
> The suspend/resume callbacks enable proper power management during
> system suspend/resume cycles.
> 
> Fixes: b2908a989c59 ("net: phy: add driver for MaxLinear MxL86110 PHY")
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>

You need to add a suitable  From: tag at the body start, or use the same
email address as the sender, whatever you prefer.

Also the resume/callback bits are IMHO more new features than fixes, but
I will not push back hard against them.

Thanks,

Paolo