[PATCH] drm/panthor: Avoid showing imported BO as exported in DebugFS output

Akash Goel posted 1 patch 1 day, 22 hours ago
drivers/gpu/drm/panthor/panthor_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/panthor: Avoid showing imported BO as exported in DebugFS output
Posted by Akash Goel 1 day, 22 hours ago
The "gems" DebugFS file shows the device-wide list of DRM GEM objects.
It displays various information about an object, including if it is
PRIME imported, PRIME exported.
This commit fixes the debugfs_bo_print() function to prevent an imported
BO from also being shown as exported in the DebugFS file output.
Both 'import_attach' and 'dma_buf' fields will not be NULL for an
imported BO.

Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
Signed-off-by: Akash Goel <akash.goel@arm.com>
---
 drivers/gpu/drm/panthor/panthor_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
index b61908fd508a..5dd92cdcf316 100644
--- a/drivers/gpu/drm/panthor/panthor_gem.c
+++ b/drivers/gpu/drm/panthor/panthor_gem.c
@@ -668,7 +668,7 @@ static void panthor_gem_debugfs_bo_print(struct panthor_gem_object *bo,
 
 	if (bo->base.base.import_attach)
 		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED;
-	if (bo->base.base.dma_buf)
+	else if (bo->base.base.dma_buf)
 		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_EXPORTED;
 
 	seq_printf(m, "0x%-8x 0x%-10x", gem_state_flags, gem_usage_flags);
-- 
2.25.1
Re: [PATCH] drm/panthor: Avoid showing imported BO as exported in DebugFS output
Posted by Steven Price 22 hours ago
On 16/12/2025 15:32, Akash Goel wrote:
> The "gems" DebugFS file shows the device-wide list of DRM GEM objects.
> It displays various information about an object, including if it is
> PRIME imported, PRIME exported.
> This commit fixes the debugfs_bo_print() function to prevent an imported
> BO from also being shown as exported in the DebugFS file output.
> Both 'import_attach' and 'dma_buf' fields will not be NULL for an
> imported BO.
> 
> Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
> Signed-off-by: Akash Goel <akash.goel@arm.com>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/gpu/drm/panthor/panthor_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index b61908fd508a..5dd92cdcf316 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -668,7 +668,7 @@ static void panthor_gem_debugfs_bo_print(struct panthor_gem_object *bo,
>  
>  	if (bo->base.base.import_attach)
>  		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED;
> -	if (bo->base.base.dma_buf)
> +	else if (bo->base.base.dma_buf)
>  		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_EXPORTED;
>  
>  	seq_printf(m, "0x%-8x 0x%-10x", gem_state_flags, gem_usage_flags);
Re: [PATCH] drm/panthor: Avoid showing imported BO as exported in DebugFS output
Posted by Boris Brezillon 1 day ago
On Tue, 16 Dec 2025 15:32:42 +0000
Akash Goel <akash.goel@arm.com> wrote:

> The "gems" DebugFS file shows the device-wide list of DRM GEM objects.
> It displays various information about an object, including if it is
> PRIME imported, PRIME exported.
> This commit fixes the debugfs_bo_print() function to prevent an imported
> BO from also being shown as exported in the DebugFS file output.
> Both 'import_attach' and 'dma_buf' fields will not be NULL for an
> imported BO.
> 
> Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
> Signed-off-by: Akash Goel <akash.goel@arm.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index b61908fd508a..5dd92cdcf316 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -668,7 +668,7 @@ static void panthor_gem_debugfs_bo_print(struct panthor_gem_object *bo,
>  
>  	if (bo->base.base.import_attach)
>  		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED;
> -	if (bo->base.base.dma_buf)
> +	else if (bo->base.base.dma_buf)
>  		gem_state_flags |= PANTHOR_DEBUGFS_GEM_STATE_FLAG_EXPORTED;
>  
>  	seq_printf(m, "0x%-8x 0x%-10x", gem_state_flags, gem_usage_flags);