From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>

Altera SoCFPGA support hardware monitor feature through mailbox. Hence,
hwmon property has to be added to the DT to enable the feature beside the
hwmon bindings and driver.

Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
---
 .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
index b42cfa78b28b..4767904c7b76 100644
--- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
+++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
@@ -62,6 +62,10 @@ properties:
     $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
     description: Optional child node for fpga manager to perform fabric configuration.
 
+  hwmon:
+    $ref: /schemas/hwmon/altr,socfpga-hwmon.yaml
+    description: Optional child node for hardware monitor to altera socfpga.
+
 required:
   - compatible
   - method
-- 
2.43.7

On Mon, Dec 15, 2025 at 10:49:23PM -0800, muhammadamirulasyraf.mohamadjamian@altera.com wrote:
> From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
> 
> Altera SoCFPGA support hardware monitor feature through mailbox. Hence,
> hwmon property has to be added to the DT to enable the feature beside the
> hwmon bindings and driver.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
> ---
>  .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> index b42cfa78b28b..4767904c7b76 100644
> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> @@ -62,6 +62,10 @@ properties:
>      $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>      description: Optional child node for fpga manager to perform fabric configuration.
>  
> +  hwmon:
> +    $ref: /schemas/hwmon/altr,socfpga-hwmon.yaml

This cannot be applied alone and you did not describe merging
dependencies anywhere.

Squash the patches or be explicit how this must be merged.

Other patches from Altera have exactly the same problem, so you keep
repeating the same.


Best regards,
Krzysztof

On 18/12/2025 4:26 pm, Krzysztof Kozlowski wrote:
> On Mon, Dec 15, 2025 at 10:49:23PM -0800, muhammadamirulasyraf.mohamadjamian@altera.com wrote:
>> From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
>>
>> Altera SoCFPGA support hardware monitor feature through mailbox. Hence,
>> hwmon property has to be added to the DT to enable the feature beside the
>> hwmon bindings and driver.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>> Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
>> ---
>>   .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> index b42cfa78b28b..4767904c7b76 100644
>> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> @@ -62,6 +62,10 @@ properties:
>>       $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>>       description: Optional child node for fpga manager to perform fabric configuration.
>>   
>> +  hwmon:
>> +    $ref: /schemas/hwmon/altr,socfpga-hwmon.yaml
> 
> This cannot be applied alone and you did not describe merging
> dependencies anywhere.
> 
> Squash the patches or be explicit how this must be merged.
> 
> Other patches from Altera have exactly the same problem, so you keep
> repeating the same.
> 
> 
> Best regards,
> Krzysztof
> 
Will squash this with PATCH 1/5 for adding dt-binding.