[PATCH v2 0/1] finalize removing the page pool members in struct page

Byungchul Park posted 1 patch 1 month, 3 weeks ago
.../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  2 +-
include/linux/mm.h                            | 27 +++----------------
include/linux/page-flags.h                    |  6 +++++
include/net/netmem.h                          | 15 +++++++++--
mm/page_alloc.c                               | 11 +++++---
net/core/netmem_priv.h                        | 20 +++++---------
net/core/page_pool.c                          | 18 +++++++++++--
7 files changed, 53 insertions(+), 46 deletions(-)
[PATCH v2 0/1] finalize removing the page pool members in struct page
Posted by Byungchul Park 1 month, 3 weeks ago
Since this patch requires to use newly introduced APIs in net tree, I've
been waiting for those to be ready in mm tree.  Now that mm tree has
been rebased so as to include the APIs, this patch can be merged to mm
tree.

This patch has been carried out in a separate thread so far for the
reviews [1]:

 [1] https://lore.kernel.org/all/20251119012709.35895-1-byungchul@sk.com/
---
Changes from v1:
	1. Drop the finalizing patch removing the pp fields of struct
	   page since I found that there is still code accessing a pp
	   field via struct page.  I will retry the finalizing patch
	   after resolving the issue.
---
Byungchul Park (1):
  mm: introduce a new page type for page pool in page type

 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  2 +-
 include/linux/mm.h                            | 27 +++----------------
 include/linux/page-flags.h                    |  6 +++++
 include/net/netmem.h                          | 15 +++++++++--
 mm/page_alloc.c                               | 11 +++++---
 net/core/netmem_priv.h                        | 20 +++++---------
 net/core/page_pool.c                          | 18 +++++++++++--
 7 files changed, 53 insertions(+), 46 deletions(-)


base-commit: d0a24447990a9d8212bfb3a692d59efa74ce9f86
-- 
2.17.1
Re: [PATCH v2 0/1] finalize removing the page pool members in struct page
Posted by Vlastimil Babka 1 month, 3 weeks ago
On 12/16/25 04:03, Byungchul Park wrote:
> Since this patch requires to use newly introduced APIs in net tree, I've
> been waiting for those to be ready in mm tree.  Now that mm tree has
> been rebased so as to include the APIs, this patch can be merged to mm
> tree.
> 
> This patch has been carried out in a separate thread so far for the
> reviews [1]:
> 
>  [1] https://lore.kernel.org/all/20251119012709.35895-1-byungchul@sk.com/
> ---
> Changes from v1:
> 	1. Drop the finalizing patch removing the pp fields of struct
> 	   page since I found that there is still code accessing a pp
> 	   field via struct page.  I will retry the finalizing patch
> 	   after resolving the issue.

Could we just make that necessary change of
drivers/net/ethernet/intel/ice/ice_ethtool.c part of this series and do it
all at once? We're changing both mm and net anyway.

Also which tree will carry the series? I assume net will want to, as the
changes are mostly there?

> ---
> Byungchul Park (1):
>   mm: introduce a new page type for page pool in page type
> 
>  .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  2 +-
>  include/linux/mm.h                            | 27 +++----------------
>  include/linux/page-flags.h                    |  6 +++++
>  include/net/netmem.h                          | 15 +++++++++--
>  mm/page_alloc.c                               | 11 +++++---
>  net/core/netmem_priv.h                        | 20 +++++---------
>  net/core/page_pool.c                          | 18 +++++++++++--
>  7 files changed, 53 insertions(+), 46 deletions(-)
> 
> 
> base-commit: d0a24447990a9d8212bfb3a692d59efa74ce9f86
Re: [PATCH v2 0/1] finalize removing the page pool members in struct page
Posted by Byungchul Park 1 month, 3 weeks ago
On Wed, Dec 17, 2025 at 02:43:07PM +0100, Vlastimil Babka wrote:
> On 12/16/25 04:03, Byungchul Park wrote:
> > Since this patch requires to use newly introduced APIs in net tree, I've
> > been waiting for those to be ready in mm tree.  Now that mm tree has
> > been rebased so as to include the APIs, this patch can be merged to mm
> > tree.
> >
> > This patch has been carried out in a separate thread so far for the
> > reviews [1]:
> >
> >  [1] https://lore.kernel.org/all/20251119012709.35895-1-byungchul@sk.com/
> > ---
> > Changes from v1:
> >       1. Drop the finalizing patch removing the pp fields of struct
> >          page since I found that there is still code accessing a pp
> >          field via struct page.  I will retry the finalizing patch
> >          after resolving the issue.
> 
> Could we just make that necessary change of
> drivers/net/ethernet/intel/ice/ice_ethtool.c part of this series and do it
> all at once? We're changing both mm and net anyway.

Yes.  That's what I think it'd better do.  1/2 can be merged separately
and Andrew took it.  I'd like to re-post 'ice fix' + 2/2 in a series if
it's allowed.

> Also which tree will carry the series? I assume net will want to, as the

I'm trying to apply changes focused on mm to mm tree, and changes
focused on net to net tree.  However, yeah, it'd make things simpler if
I can go with a single series for mm tree.

	Byungchul

> changes are mostly there?
> 
> > ---
> > Byungchul Park (1):
> >   mm: introduce a new page type for page pool in page type
> >
> >  .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  2 +-
> >  include/linux/mm.h                            | 27 +++----------------
> >  include/linux/page-flags.h                    |  6 +++++
> >  include/net/netmem.h                          | 15 +++++++++--
> >  mm/page_alloc.c                               | 11 +++++---
> >  net/core/netmem_priv.h                        | 20 +++++---------
> >  net/core/page_pool.c                          | 18 +++++++++++--
> >  7 files changed, 53 insertions(+), 46 deletions(-)
> >
> >
> > base-commit: d0a24447990a9d8212bfb3a692d59efa74ce9f86
Re: [PATCH v2 0/1] finalize removing the page pool members in struct page
Posted by Paolo Abeni 1 month, 2 weeks ago
On 12/18/25 1:17 AM, Byungchul Park wrote:
> On Wed, Dec 17, 2025 at 02:43:07PM +0100, Vlastimil Babka wrote:
>> On 12/16/25 04:03, Byungchul Park wrote:
>>> Since this patch requires to use newly introduced APIs in net tree, I've
>>> been waiting for those to be ready in mm tree.  Now that mm tree has
>>> been rebased so as to include the APIs, this patch can be merged to mm
>>> tree.
>>>
>>> This patch has been carried out in a separate thread so far for the
>>> reviews [1]:
>>>
>>>  [1] https://lore.kernel.org/all/20251119012709.35895-1-byungchul@sk.com/
>>> ---
>>> Changes from v1:
>>>       1. Drop the finalizing patch removing the pp fields of struct
>>>          page since I found that there is still code accessing a pp
>>>          field via struct page.  I will retry the finalizing patch
>>>          after resolving the issue.
>>
>> Could we just make that necessary change of
>> drivers/net/ethernet/intel/ice/ice_ethtool.c part of this series and do it
>> all at once? We're changing both mm and net anyway.
> 
> Yes.  That's what I think it'd better do.  1/2 can be merged separately
> and Andrew took it.  I'd like to re-post 'ice fix' + 2/2 in a series if
> it's allowed.
> 
>> Also which tree will carry the series? I assume net will want to, as the
> 
> I'm trying to apply changes focused on mm to mm tree, and changes
> focused on net to net tree.  However, yeah, it'd make things simpler if
> I can go with a single series for mm tree.

I *think* that the ice patch should go via the net-next tree (and
ideally via the iwl tree first). Also it looks like both patches could
cause quite a bit of conflicts, as the page pool code and the ice driver
are touched frequently.

Perhaps the easier/cleaner way to handle this is publishing a stable
branch somewhere based on the most recent common ancestor and let both
the mm and the net-next tree pull from it? Other opinions welcome!

Anyway the net-next tree is and will be closed up to Jan 2.

Cheers,

Paolo