1. Patchew
  2. linux
  3. View series

[PATCH] perf Documentation: Correct branch stack sampling call-stack option

Dapeng Mi posted 1 patch 1 month, 3 weeks ago 
tools/perf/Documentation/perf-record.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf Documentation: Correct branch stack sampling call-stack option
Posted by Dapeng Mi 1 month, 3 weeks ago 
The correct call-stack option for branch stack sampling should be "stack"
instead of "call_stack". Correct it.

$perf record -e instructions -j call_stack -- sleep 1
unknown branch filter call_stack, check man page

 Usage: perf record [<options>] [<command>]
    or: perf record [<options>] -- <command> [<options>]

    -j, --branch-filter <branch filter mask>
                          branch stack filter modes

Cc: stable@vger.kernel.org
Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
---
 tools/perf/Documentation/perf-record.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index e8b9aadbbfa5..3d19e77c9c53 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -454,7 +454,7 @@ following filters are defined:
 	- no_tx: only when the target is not in a hardware transaction
 	- abort_tx: only when the target is a hardware transaction abort
 	- cond: conditional branches
-	- call_stack: save call stack
+	- stack: save call stack
 	- no_flags: don't save branch flags e.g prediction, misprediction etc
 	- no_cycles: don't save branch cycles
 	- hw_index: save branch hardware index

base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
-- 
2.34.1
Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
Posted by Mi, Dapeng 1 month ago 
@Arnaldo, @Kim, @Ian

Kindly ping ... 

On 12/16/2025 9:39 AM, Dapeng Mi wrote:
> The correct call-stack option for branch stack sampling should be "stack"
> instead of "call_stack". Correct it.
>
> $perf record -e instructions -j call_stack -- sleep 1
> unknown branch filter call_stack, check man page
>
>  Usage: perf record [<options>] [<command>]
>     or: perf record [<options>] -- <command> [<options>]
>
>     -j, --branch-filter <branch filter mask>
>                           branch stack filter modes
>
> Cc: stable@vger.kernel.org
> Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> ---
>  tools/perf/Documentation/perf-record.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index e8b9aadbbfa5..3d19e77c9c53 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -454,7 +454,7 @@ following filters are defined:
>  	- no_tx: only when the target is not in a hardware transaction
>  	- abort_tx: only when the target is a hardware transaction abort
>  	- cond: conditional branches
> -	- call_stack: save call stack
> +	- stack: save call stack
>  	- no_flags: don't save branch flags e.g prediction, misprediction etc
>  	- no_cycles: don't save branch cycles
>  	- hw_index: save branch hardware index
>
> base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
Posted by Namhyung Kim 1 month ago 
Hello,

On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
> @Arnaldo, @Kim, @Ian
> 
> Kindly ping ... 

Sorry for the delay.

> 
> On 12/16/2025 9:39 AM, Dapeng Mi wrote:
> > The correct call-stack option for branch stack sampling should be "stack"
> > instead of "call_stack". Correct it.
> >
> > $perf record -e instructions -j call_stack -- sleep 1
> > unknown branch filter call_stack, check man page
> >
> >  Usage: perf record [<options>] [<command>]
> >     or: perf record [<options>] -- <command> [<options>]
> >
> >     -j, --branch-filter <branch filter mask>
> >                           branch stack filter modes
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> > ---
> >  tools/perf/Documentation/perf-record.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> > index e8b9aadbbfa5..3d19e77c9c53 100644
> > --- a/tools/perf/Documentation/perf-record.txt
> > +++ b/tools/perf/Documentation/perf-record.txt
> > @@ -454,7 +454,7 @@ following filters are defined:
> >  	- no_tx: only when the target is not in a hardware transaction
> >  	- abort_tx: only when the target is a hardware transaction abort
> >  	- cond: conditional branches
> > -	- call_stack: save call stack
> > +	- stack: save call stack
> >  	- no_flags: don't save branch flags e.g prediction, misprediction etc
> >  	- no_cycles: don't save branch cycles
> >  	- hw_index: save branch hardware index
> >
> > base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
Posted by Arnaldo Carvalho de Melo 3 weeks, 4 days ago 
On Wed, Jan 07, 2026 at 10:14:46PM -0800, Namhyung Kim wrote:
> Hello,
> 
> On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
> > @Arnaldo, @Kim, @Ian
> > 
> > Kindly ping ... 
> 
> Sorry for the delay.

Ditto

> > > Cc: stable@vger.kernel.org
> > > Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> > > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> 
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next,

- Arnaldo
Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
Posted by Mi, Dapeng 1 month ago 
On 1/8/2026 2:14 PM, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
>> @Arnaldo, @Kim, @Ian
>>
>> Kindly ping ... 
> Sorry for the delay.
>
>> On 12/16/2025 9:39 AM, Dapeng Mi wrote:
>>> The correct call-stack option for branch stack sampling should be "stack"
>>> instead of "call_stack". Correct it.
>>>
>>> $perf record -e instructions -j call_stack -- sleep 1
>>> unknown branch filter call_stack, check man page
>>>
>>>  Usage: perf record [<options>] [<command>]
>>>     or: perf record [<options>] -- <command> [<options>]
>>>
>>>     -j, --branch-filter <branch filter mask>
>>>                           branch stack filter modes
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
>>> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks a lot. :)


>
> Thanks,
> Namhyung
>
>>> ---
>>>  tools/perf/Documentation/perf-record.txt | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
>>> index e8b9aadbbfa5..3d19e77c9c53 100644
>>> --- a/tools/perf/Documentation/perf-record.txt
>>> +++ b/tools/perf/Documentation/perf-record.txt
>>> @@ -454,7 +454,7 @@ following filters are defined:
>>>  	- no_tx: only when the target is not in a hardware transaction
>>>  	- abort_tx: only when the target is a hardware transaction abort
>>>  	- cond: conditional branches
>>> -	- call_stack: save call stack
>>> +	- stack: save call stack
>>>  	- no_flags: don't save branch flags e.g prediction, misprediction etc
>>>  	- no_cycles: don't save branch cycles
>>>  	- hw_index: save branch hardware index
>>>
>>> base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.