1. Patchew
  2. linux
  3. [PATCH v3 0/2] Improve older camss supply descriptions
  4. View patch

[PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

David Heidelberg via B4 Relay posted 2 patches 1 month, 3 weeks ago
[PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description
Posted by David Heidelberg via B4 Relay 1 month, 3 weeks ago 
From: David Heidelberg <david@ixit.cz>

Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
voltage from the description.

Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
index 019caa2b09c32..4986d18d1a2da 100644
--- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
@@ -130,7 +130,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index ee35e3bc97ffd..e4b0b7ffdc336 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -129,7 +129,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
index c99fe4106eee9..9cba6e0819fb1 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
@@ -268,7 +268,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
index 35c40fe223767..61222839556bd 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
@@ -95,7 +95,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 82bf4689d3300..03b9b34460b0a 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -211,7 +211,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index ebf68ff4ab961..acf9c54682107 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -300,7 +300,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names

-- 
2.51.0
Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago 
On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.

You did not remove the voltage. Anyway, both commits should be squashed.

> 
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..4986d18d1a2da 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>  
>    vdda-pll-supply:
>      description:
> -      Phandle to 1.8V regulator supply to PHY refclk pll block.
> +      1.2V regulator supply to CSIPHY IP blocks.

"...that supply is a regulator supply" so you still decided to go that
way. Why? I think I could not write this clearer.

Best regards,
Krzysztof
Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description
Posted by David Heidelberg 1 month, 3 weeks ago 
On 18/12/2025 09:12, Krzysztof Kozlowski wrote:
> On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
>> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
>> voltage from the description.
> 
> You did not remove the voltage. Anyway, both commits should be squashed.
> 
>>
>> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> index 019caa2b09c32..4986d18d1a2da 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> @@ -130,7 +130,7 @@ properties:
>>   
>>     vdda-pll-supply:
>>       description:
>> -      Phandle to 1.8V regulator supply to PHY refclk pll block.
>> +      1.2V regulator supply to CSIPHY IP blocks.
> 
> "...that supply is a regulator supply" so you still decided to go that
> way. Why? I think I could not write this clearer.

Oh! Vladimir mentioned the supplies should look like in

 > names like found in qcom,x1e80100-camss.yaml, qcom,qcm2290-camss.yaml 
and qcom,sm8650-camss.yaml

I blindly considered these to be "examples how it should look like" and 
used the more recent description without checking them.

I'll squash the commits in next version and rephrase all camss the 
supplies correctly, if it make sense to you.

Sorry for the inconvenience and thanks.
David

> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg
Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description
Posted by Bryan O'Donoghue 1 month, 3 weeks ago 
On 16/12/2025 12:24, David Heidelberg via B4 Relay wrote:
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")

This Fixes tag pertains to just one commit, whereas your patch modifies 
files associated with ~ 6 commits.

Please drop the Fixes:

---
bod
Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description
Posted by David Heidelberg 1 month, 3 weeks ago 
On 16/12/2025 13:30, Bryan O'Donoghue wrote:
> On 16/12/2025 12:24, David Heidelberg via B4 Relay wrote:
>> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda 
>> regulator descriptions sdm845")
> 
> This Fixes tag pertains to just one commit, whereas your patch modifies 
> files associated with ~ 6 commits.
> 
> Please drop the Fixes:

Sure. If no additional changes will be requested, please drop the Fixes 
line for me.

Thank you

> 
> ---
> bod

-- 
David Heidelberg

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.