[PATCH 1/5] staging: iio: ad9832: clean up whitespace

Tomas Borquez posted 5 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH 1/5] staging: iio: ad9832: clean up whitespace
Posted by Tomas Borquez 1 month, 3 weeks ago
Remove unnecessary blank lines between comment sections to improve
readability.

Signed-off-by: Tomas Borquez <tomasborquez13@gmail.com>
---
 drivers/staging/iio/frequency/ad9832.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index e2ad3e5a7a..00813dab7c 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -26,7 +26,6 @@
 #include "dds.h"
 
 /* Registers */
-
 #define AD9832_FREQ0LL		0x0
 #define AD9832_FREQ0HL		0x1
 #define AD9832_FREQ0LM		0x2
@@ -50,7 +49,6 @@
 #define AD9832_OUTPUT_EN	0x13
 
 /* Command Control Bits */
-
 #define AD9832_CMD_PHA8BITSW	0x1
 #define AD9832_CMD_PHA16BITSW	0x0
 #define AD9832_CMD_FRE8BITSW	0x3
@@ -90,7 +88,6 @@
  * @phase_data:		tuning word spi transmit buffer
  * @freq_data:		tuning word spi transmit buffer
  */
-
 struct ad9832_state {
 	struct spi_device		*spi;
 	struct clk			*mclk;
@@ -327,7 +324,6 @@ static int ad9832_probe(struct spi_device *spi)
 	indio_dev->modes = INDIO_DIRECT_MODE;
 
 	/* Setup default messages */
-
 	st->xfer.tx_buf = &st->data;
 	st->xfer.len = 2;
 
-- 
2.43.0
Re: [PATCH 1/5] staging: iio: ad9832: clean up whitespace
Posted by Marcelo Schmitt 1 month, 3 weeks ago
Hi Tomas,

LGTM.
One minor suggestion.

On 12/15, Tomas Borquez wrote:
> Remove unnecessary blank lines between comment sections to improve
> readability.
> 
> Signed-off-by: Tomas Borquez <tomasborquez13@gmail.com>
> ---
>  drivers/staging/iio/frequency/ad9832.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index e2ad3e5a7a..00813dab7c 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -26,7 +26,6 @@
>  #include "dds.h"
>  
>  /* Registers */
> -
>  #define AD9832_FREQ0LL		0x0
>  #define AD9832_FREQ0HL		0x1
>  #define AD9832_FREQ0LM		0x2
> @@ -50,7 +49,6 @@
>  #define AD9832_OUTPUT_EN	0x13

There is a blank line between AD9832_PHASE3H and AD9832_PHASE_SYM that could
also be removed, IMO.
 #define AD9832_PHASE3L		0xE
 #define AD9832_PHASE3H		0xF
-
 #define AD9832_PHASE_SYM	0x10
 #define AD9832_FREQ_SYM		0x11

>  
>  /* Command Control Bits */
> -
>  #define AD9832_CMD_PHA8BITSW	0x1
Re: [PATCH 1/5] staging: iio: ad9832: clean up whitespace
Posted by Jonathan Cameron 1 month, 2 weeks ago
On Thu, 18 Dec 2025 11:27:18 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:

> Hi Tomas,
> 
> LGTM.
> One minor suggestion.
> 
> On 12/15, Tomas Borquez wrote:
> > Remove unnecessary blank lines between comment sections to improve
> > readability.
> > 
> > Signed-off-by: Tomas Borquez <tomasborquez13@gmail.com>
> > ---
> >  drivers/staging/iio/frequency/ad9832.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index e2ad3e5a7a..00813dab7c 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -26,7 +26,6 @@
> >  #include "dds.h"
> >  
> >  /* Registers */
> > -
> >  #define AD9832_FREQ0LL		0x0
> >  #define AD9832_FREQ0HL		0x1
> >  #define AD9832_FREQ0LM		0x2
> > @@ -50,7 +49,6 @@
> >  #define AD9832_OUTPUT_EN	0x13  
> 
> There is a blank line between AD9832_PHASE3H and AD9832_PHASE_SYM that could
> also be removed, IMO.
>  #define AD9832_PHASE3L		0xE
>  #define AD9832_PHASE3H		0xF
> -
>  #define AD9832_PHASE_SYM	0x10
>  #define AD9832_FREQ_SYM		0x11
> 
Agreed. In the interests of efficiency all round I applied this
tweak whilst picking up the patch.

For this sort of cleanup series I often to it piecemeal. So I've
applied this one (no idea if I'll apply the later ones yet!)

Jonathan

> >  
> >  /* Command Control Bits */
> > -
> >  #define AD9832_CMD_PHA8BITSW	0x1