[PATCH] md: Fix static checker warning in analyze_sbs

linan666@huaweicloud.com posted 1 patch 1 month, 3 weeks ago
drivers/md/md.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH] md: Fix static checker warning in analyze_sbs
Posted by linan666@huaweicloud.com 1 month, 3 weeks ago
From: Li Nan <linan122@huawei.com>

The following warn is reported:

 drivers/md/md.c:3912 analyze_sbs()
 warn: iterator 'i' not incremented

Fixes: d8730f0cf4ef ("md: Remove deprecated CONFIG_MD_MULTIPATH")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-raid/7e2e95ce-3740-09d8-a561-af6bfb767f18@huaweicloud.com/T/#t
Signed-off-by: Li Nan <linan122@huawei.com>
---
 drivers/md/md.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 648fbf1b1fe7..dac03b831efa 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3907,7 +3907,6 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe
 
 static int analyze_sbs(struct mddev *mddev)
 {
-	int i;
 	struct md_rdev *rdev, *freshest, *tmp;
 
 	freshest = NULL;
@@ -3934,11 +3933,9 @@ static int analyze_sbs(struct mddev *mddev)
 	super_types[mddev->major_version].
 		validate_super(mddev, NULL/*freshest*/, freshest);
 
-	i = 0;
 	rdev_for_each_safe(rdev, tmp, mddev) {
 		if (mddev->max_disks &&
-		    (rdev->desc_nr >= mddev->max_disks ||
-		     i > mddev->max_disks)) {
+		    rdev->desc_nr >= mddev->max_disks) {
 			pr_warn("md: %s: %pg: only %d devices permitted\n",
 				mdname(mddev), rdev->bdev,
 				mddev->max_disks);
-- 
2.39.2
Re: [PATCH] md: Fix static checker warning in analyze_sbs
Posted by Yu Kuai 1 month, 2 weeks ago
在 2025/12/15 20:44, linan666@huaweicloud.com 写道:

> From: Li Nan<linan122@huawei.com>
>
> The following warn is reported:
>
>   drivers/md/md.c:3912 analyze_sbs()
>   warn: iterator 'i' not incremented
>
> Fixes: d8730f0cf4ef ("md: Remove deprecated CONFIG_MD_MULTIPATH")
> Reported-by: Dan Carpenter<dan.carpenter@linaro.org>
> Closes:https://lore.kernel.org/linux-raid/7e2e95ce-3740-09d8-a561-af6bfb767f18@huaweicloud.com/T/#t
> Signed-off-by: Li Nan<linan122@huawei.com>
> ---
>   drivers/md/md.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Applied to md-6.19

-- 
Thansk,
Kuai