[PATCH] Remove duplicate header file references

l00580197 posted 1 patch 1 month, 3 weeks ago
kernel/liveupdate/kexec_handover.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] Remove duplicate header file references
Posted by l00580197 1 month, 3 weeks ago
From: Long Wei <longwei27@huawei.com>

From: Long Wei <longwei27@huawei.com>

kexec_handover_internal.h is included twice in kexec_handover.c.
Remove the redundant first inclusion to eliminate the duplication.

Signed-off-by: Long Wei <longwei27@huawei.com>
---
 kernel/liveupdate/kexec_handover.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index 9dc51fab604f..1962b6052840 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -24,7 +24,6 @@

 #include <asm/early_ioremap.h>

-#include "kexec_handover_internal.h"
 /*
  * KHO is tightly coupled with mm init and needs access to some of mm
  * internal APIs.
--
2.43.0
[PATCH v3] kho: Remove duplicate header file references
Posted by l00580197 1 month, 3 weeks ago
From: Long Wei <longwei27@huawei.com>

kexec_handover_internal.h is included twice in kexec_handover.c.
Remove the redundant first inclusion to eliminate the duplication.

Signed-off-by: Long Wei <longwei27@huawei.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
---
Changes in v3:
- move changelog into stat section.

Changes in v2:
- Fixed the malformed commit message header (removed duplicate 'From:' line).
- Added module prefix 'kho:' to the subject.

 kernel/liveupdate/kexec_handover.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index 9dc51fab604f..1962b6052840 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -24,7 +24,6 @@

 #include <asm/early_ioremap.h>

-#include "kexec_handover_internal.h"
 /*
  * KHO is tightly coupled with mm init and needs access to some of mm
  * internal APIs.
--
2.43.0
[PATCH v2] kho: Remove duplicate header file references
Posted by l00580197 1 month, 3 weeks ago
From: Long Wei <longwei27@huawei.com>

Changes in v2:
- Fixed the malformed commit message header (removed duplicate 'From:' line).
- Added module prefix 'kho:' to the subject.

kexec_handover_internal.h is included twice in kexec_handover.c.
Remove the redundant first inclusion to eliminate the duplication.

Signed-off-by: Long Wei <longwei27@huawei.com>
---
 kernel/liveupdate/kexec_handover.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index 9dc51fab604f..1962b6052840 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -24,7 +24,6 @@

 #include <asm/early_ioremap.h>

-#include "kexec_handover_internal.h"
 /*
  * KHO is tightly coupled with mm init and needs access to some of mm
  * internal APIs.
--
2.43.0
Re: [PATCH v2] kho: Remove duplicate header file references
Posted by Pasha Tatashin 1 month, 3 weeks ago
On Tue, Dec 16, 2025 at 1:45 AM l00580197 <longwei27@huawei.com> wrote:
>
> From: Long Wei <longwei27@huawei.com>
>
> Changes in v2:
> - Fixed the malformed commit message header (removed duplicate 'From:' line).
> - Added module prefix 'kho:' to the subject.

Please move changelog into stat section, so it does not appear part of
the commit log.

>
> kexec_handover_internal.h is included twice in kexec_handover.c.
> Remove the redundant first inclusion to eliminate the duplication.
>
> Signed-off-by: Long Wei <longwei27@huawei.com>

With the above:
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>

> ---
>  kernel/liveupdate/kexec_handover.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 9dc51fab604f..1962b6052840 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -24,7 +24,6 @@
>
>  #include <asm/early_ioremap.h>
>
> -#include "kexec_handover_internal.h"
>  /*
>   * KHO is tightly coupled with mm init and needs access to some of mm
>   * internal APIs.
> --
> 2.43.0