[PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c

Adrish Bora posted 1 patch 20 hours ago
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 --------
1 file changed, 8 deletions(-)
[PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c
Posted by Adrish Bora 20 hours ago
Remove commented-out dead code in netdev_close().
The code was previously commented out and is not needed.

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Adrish Bora <adrishbora@gmail.com>
---
Changes in v2:
  - Removed the dead code entirely instead of fixing the comment style,
    as suggested by Dan Carpenter.
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..df839ea1bf1d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,6 @@ static int netdev_close(struct net_device *pnetdev)
 	padapter->net_closed = true;
 	padapter->netif_up = false;
 
-/*if (!padapter->hw_init_completed)
-	{
-
-		padapter->bDriverStopped = true;
-
-		rtw_dev_unload(padapter);
-	}
-	else*/
 	if (pwrctl->rf_pwrstate == rf_on) {
 		/* s1. */
 		if (pnetdev) {
-- 
2.43.0
Re: [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c
Posted by Dan Carpenter 19 hours ago
On Mon, Dec 15, 2025 at 06:31:02AM +0000, Adrish Bora wrote:
> Remove commented-out dead code in netdev_close().
> The code was previously commented out and is not needed.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Adrish Bora <adrishbora@gmail.com>
> ---
> Changes in v2:
>   - Removed the dead code entirely instead of fixing the comment style,
>     as suggested by Dan Carpenter.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter