[PATCH 2/3] media: mali-c55: Remove duplicated version check

Jacopo Mondi posted 3 patches 1 month, 3 weeks ago
[PATCH 2/3] media: mali-c55: Remove duplicated version check
Posted by Jacopo Mondi 1 month, 3 weeks ago
The Mali C55 driver uses the v4l2-isp framework, which performs
validation of the parameters buffer versioning in the
v4l2_isp_params_validate_buffer() function.

It is not necessary to replicate the validation of the parameters buffer
versioning in the platform-specific implementation.

Remove it.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 drivers/media/platform/arm/mali-c55/mali-c55-params.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
index 082cda4f4f63e880162896ff0f893cd774982d51..be0e909bcf29f62c01c75d711c21278faf7c9de5 100644
--- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c
+++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
@@ -582,13 +582,6 @@ static int mali_c55_params_buf_prepare(struct vb2_buffer *vb)
 	struct mali_c55 *mali_c55 = params->mali_c55;
 	int ret;
 
-	if (config->version != MALI_C55_PARAM_BUFFER_V1) {
-		dev_dbg(mali_c55->dev,
-			"Unsupported extensible format version: %u\n",
-			config->version);
-		return -EINVAL;
-	}
-
 	ret = v4l2_isp_params_validate_buffer_size(mali_c55->dev, vb,
 			v4l2_isp_params_buffer_size(MALI_C55_PARAMS_MAX_SIZE));
 	if (ret)

-- 
2.52.0
Re: [PATCH 2/3] media: mali-c55: Remove duplicated version check
Posted by Dan Scally 1 month, 3 weeks ago

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which performs
> validation of the parameters buffer versioning in the
> v4l2_isp_params_validate_buffer() function.
> 
> It is not necessary to replicate the validation of the parameters buffer
> versioning in the platform-specific implementation.
> 
> Remove it.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
>   drivers/media/platform/arm/mali-c55/mali-c55-params.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> index 082cda4f4f63e880162896ff0f893cd774982d51..be0e909bcf29f62c01c75d711c21278faf7c9de5 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> @@ -582,13 +582,6 @@ static int mali_c55_params_buf_prepare(struct vb2_buffer *vb)
>   	struct mali_c55 *mali_c55 = params->mali_c55;
>   	int ret;
>   
> -	if (config->version != MALI_C55_PARAM_BUFFER_V1) {
> -		dev_dbg(mali_c55->dev,
> -			"Unsupported extensible format version: %u\n",
> -			config->version);
> -		return -EINVAL;
> -	}
> -
>   	ret = v4l2_isp_params_validate_buffer_size(mali_c55->dev, vb,
>   			v4l2_isp_params_buffer_size(MALI_C55_PARAMS_MAX_SIZE));
>   	if (ret)
>