The Mali C55 driver uses the v4l2-isp framework, which defines its own
versioning numbers.

Do not use the Mali C55 specific version identifier in the code example
in the documentation of the Mali C55 stats and params metadata formats.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
--- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
+++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
@@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
 	struct v4l2_isp_params_buffer *params =
 		(struct v4l2_isp_params_buffer *)buffer;
 
-	params->version = MALI_C55_PARAM_BUFFER_V1;
+	params->version = V4L2_ISP_PARAMS_VERSION_V1;
 	params->data_size = 0;
 
 	void *data = (void *)params->data;

-- 
2.52.0

Morning Jacopo - thanks for the set

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which defines its own
> versioning numbers.
> 
> Do not use the Mali C55 specific version identifier in the code example
> in the documentation of the Mali C55 stats and params metadata formats.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
>   	struct v4l2_isp_params_buffer *params =
>   		(struct v4l2_isp_params_buffer *)buffer;
>   
> -	params->version = MALI_C55_PARAM_BUFFER_V1;
> +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
>   	params->data_size = 0;
>   
>   	void *data = (void *)params->data;
>

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which defines its own
> versioning numbers.
> 
> Do not use the Mali C55 specific version identifier in the code example
> in the documentation of the Mali C55 stats and params metadata formats.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
>   	struct v4l2_isp_params_buffer *params =
>   		(struct v4l2_isp_params_buffer *)buffer;
> 
> -	params->version = MALI_C55_PARAM_BUFFER_V1;
> +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
>   	params->data_size = 0;
> 
>   	void *data = (void *)params->data;
> 
> --
> 2.52.0
> 
> 

Feels like this should have a Fixes tag.

---
bod

Hi Brian

On Tue, Dec 16, 2025 at 12:38:16PM +0000, Bryan O'Donoghue wrote:
> On 15/12/2025 13:20, Jacopo Mondi wrote:
> > The Mali C55 driver uses the v4l2-isp framework, which defines its own
> > versioning numbers.
> >
> > Do not use the Mali C55 specific version identifier in the code example
> > in the documentation of the Mali C55 stats and params metadata formats.
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > ---
> >   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> > --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
> >   	struct v4l2_isp_params_buffer *params =
> >   		(struct v4l2_isp_params_buffer *)buffer;
> >
> > -	params->version = MALI_C55_PARAM_BUFFER_V1;
> > +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
> >   	params->data_size = 0;
> >
> >   	void *data = (void *)params->data;
> >
> > --
> > 2.52.0
> >
> >
>
> Feels like this should have a Fixes tag.

I want this collected for v6.19, the same release the driver will be
collected in. Is it worth a Fixes and a cc to Stable if this patch
and the driver that it "fixes" land in the same release ?

>
> ---
> bod

On 17/12/2025 08:11, Jacopo Mondi wrote:
>> Feels like this should have a Fixes tag.
> I want this collected for v6.19, the same release the driver will be
> collected in. Is it worth a Fixes and a cc to Stable if this patch
> and the driver that it "fixes" land in the same release ?

Ah no not if its in the same release :)

---
bod