The entries later in `enum dmi_entry_type` don't match the SMBIOS
specification.  The entry for type 33: `64-Bit Memory Error Information`
is not present and thus the index for all later entries is incorrect.

Add the missing type 33 entry.

Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---
 include/linux/dmi.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/dmi.h b/include/linux/dmi.h
index 927f8a8b7a1dd..a809b5095c259 100644
--- a/include/linux/dmi.h
+++ b/include/linux/dmi.h
@@ -60,6 +60,7 @@ enum dmi_entry_type {
 	DMI_ENTRY_OOB_REMOTE_ACCESS,
 	DMI_ENTRY_BIS_ENTRY,
 	DMI_ENTRY_SYSTEM_BOOT,
+	DMI_ENTRY_MEMORY_INFO,
 	DMI_ENTRY_MGMT_DEV,
 	DMI_ENTRY_MGMT_DEV_COMPONENT,
 	DMI_ENTRY_MGMT_DEV_THRES,
-- 
2.43.0

On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote:
> The entries later in `enum dmi_entry_type` don't match the SMBIOS
> specification.  The entry for type 33: `64-Bit Memory Error Information`
> is not present and thus the index for all later entries is incorrect.
> 
> Add the missing type 33 entry.

Types 43, 44, 45, and 46 are missing also. Should those be added as
well?

Probably not needed right now, but would be good to add them in a
future patch. I think there's precedent for keeping definitions up to
date with the spec even if they're not immediately used. ACPI does
this, I think.

> 
> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

On 12/15/25 3:11 PM, Yazen Ghannam wrote:
> On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote:
>> The entries later in `enum dmi_entry_type` don't match the SMBIOS
>> specification.  The entry for type 33: `64-Bit Memory Error Information`
>> is not present and thus the index for all later entries is incorrect.
>>
>> Add the missing type 33 entry.
> 
> Types 43, 44, 45, and 46 are missing also. Should those be added as
> well?
> 
> Probably not needed right now, but would be good to add them in a
> future patch. I think there's precedent for keeping definitions up to
> date with the spec even if they're not immediately used. ACPI does
> this, I think.

OK, thanks.  I'll tail another patch to the next spin of the series to 
add those too.

> 
>>
>> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
>> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> 
> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> Thanks,
> Yazen