[v1] staging: rtl8723bs: fix block comment coding style

[PATCH] staging: rtl8723bs: fix block comment coding style

Posted by Adrish Bora 1 month, 3 weeks ago

Fix the block comment style in os_intfs.c to match the kernel coding style.
The comment was previously lacking the required asterisks on subsequent lines.

Signed-off-by: Adrish Bora <adrishbora@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..ca841cc61076 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
 	padapter->net_closed = true;
 	padapter->netif_up = false;
 
-/*if (!padapter->hw_init_completed)
-	{
-
-		padapter->bDriverStopped = true;
-
-		rtw_dev_unload(padapter);
-	}
-	else*/
+/*
+ * if (!padapter->hw_init_completed)
+ *	{
+ *
+ *		padapter->bDriverStopped = true;
+ *
+ *		rtw_dev_unload(padapter);
+ *	}
+ *	else
+ */
 	if (pwrctl->rf_pwrstate == rf_on) {
 		/* s1. */
 		if (pnetdev) {
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: fix block comment coding style

Posted by Greg KH 1 month, 3 weeks ago

On Sun, Dec 14, 2025 at 02:26:08PM +0000, Adrish Bora wrote:
> Fix the block comment style in os_intfs.c to match the kernel coding style.
> The comment was previously lacking the required asterisks on subsequent lines.
> 
> Signed-off-by: Adrish Bora <adrishbora@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..ca841cc61076 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + *	{
> + *
> + *		padapter->bDriverStopped = true;
> + *
> + *		rtw_dev_unload(padapter);
> + *	}
> + *	else
> + */

If this code has been commented out for a long time, please just delete
it, no need to make it "pretty" with a different style of comment block.

thanks,

greg k-h