pnfs: add checking of the return value of sscanf

[PATCH] pnfs: add checking of the return value of sscanf

rom.wang posted 1 patch 1 day, 16 hours ago

Download mbox

fs/nfs/pnfs_nfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] pnfs: add checking of the return value of sscanf

Posted by rom.wang 1 day, 16 hours ago

From: Yufeng Wang <wangyufeng@kylinos.cn>

Add a missing check of return value of sscanf

Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
---
 fs/nfs/pnfs_nfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
index 9976cc16b689..c6a999f6220d 100644
--- a/fs/nfs/pnfs_nfs.c
+++ b/fs/nfs/pnfs_nfs.c
@@ -1114,7 +1114,8 @@ nfs4_decode_mp_ds_addr(struct net *net, struct xdr_stream *xdr, gfp_t gfp_flags)
 	}
 
 	portstr++;
-	sscanf(portstr, "%d-%d", &tmp[0], &tmp[1]);
+	if (sscanf(portstr, "%d-%d", &tmp[0], &tmp[1]) != 2)
+		goto out_free_da;
 	port = htons((tmp[0] << 8) | (tmp[1]));
 
 	switch (da->da_addr.ss_family) {
-- 
2.34.1