[PATCH next] ALSA: hda: Remove unnecessary print function dev_err()

Jiapeng Chong posted 1 patch 1 day, 19 hours ago
sound/hda/controllers/cix-ipbloq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH next] ALSA: hda: Remove unnecessary print function dev_err()
Posted by Jiapeng Chong 1 day, 19 hours ago
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

./sound/hda/controllers/cix-ipbloq.c:119:2-9: line 119 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=28045
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 sound/hda/controllers/cix-ipbloq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/hda/controllers/cix-ipbloq.c b/sound/hda/controllers/cix-ipbloq.c
index 99f9f48e91d4..c1084a915c13 100644
--- a/sound/hda/controllers/cix-ipbloq.c
+++ b/sound/hda/controllers/cix-ipbloq.c
@@ -115,10 +115,8 @@ static int cix_ipbloq_hda_init(struct cix_ipbloq_hda *hda,
 	bus->addr = res->start;
 
 	irq_id = platform_get_irq(pdev, 0);
-	if (irq_id < 0) {
-		dev_err(hda->dev, "failed to get the irq, err = %d\n", irq_id);
+	if (irq_id < 0)
 		return irq_id;
-	}
 
 	err = devm_request_irq(hda->dev, irq_id, azx_interrupt,
 			       0, KBUILD_MODNAME, chip);
-- 
2.43.7
Re: [PATCH next] ALSA: hda: Remove unnecessary print function dev_err()
Posted by Takashi Iwai 16 hours ago
On Fri, 12 Dec 2025 07:24:10 +0100,
Jiapeng Chong wrote:
> 
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> ./sound/hda/controllers/cix-ipbloq.c:119:2-9: line 119 is redundant because platform_get_irq() already prints an error.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=28045
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thanks, applied.


Takashi