Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +- Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +- Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +- Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +- Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +- Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
From: David Heidelberg <david@ixit.cz>
Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
voltage from the description.
Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Added only Fixes tag for the initial commit, not all the copy-paste
propagated ones.
---
Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
index 019caa2b09c32..9009cfe993d75 100644
--- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
@@ -130,7 +130,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index ee35e3bc97ffd..cb922f90fe900 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -129,7 +129,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
index c99fe4106eee9..2231d7216f62a 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
@@ -268,7 +268,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
index 35c40fe223767..8e6ca94c88695 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
@@ -95,7 +95,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 82bf4689d3300..d50e096b900db 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -211,7 +211,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index ebf68ff4ab961..ccd2d024bfd10 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -300,7 +300,7 @@ properties:
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ Phandle to regulator supply to PHY refclk pll block.
required:
- clock-names
---
base-commit: d9771d0dbe18dd643760431870a6abf9b0866bb0
change-id: 20251212-docs-camss-fixes-0fa525271951
Best regards,
--
David Heidelberg <david@ixit.cz>On 12/13/25 00:55, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.
>
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Added only Fixes tag for the initial commit, not all the copy-paste
> propagated ones.
Generally it should be possible to specify a list of Fixes: tags.
However, despite the change is the proper one, there is an opinion that Fixes
tags are not applicable to dt bindings with a given reason that only executed
code can be fixed. So you may be asked to remove even a single Fixes tag.
> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..9009cfe993d75 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index ee35e3bc97ffd..cb922f90fe900 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -129,7 +129,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index c99fe4106eee9..2231d7216f62a 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -268,7 +268,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> index 35c40fe223767..8e6ca94c88695 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> @@ -95,7 +95,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 82bf4689d3300..d50e096b900db 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -211,7 +211,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index ebf68ff4ab961..ccd2d024bfd10 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> @@ -300,7 +300,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
>
As for the change itself it is good, I'd prefer to get a correction
to 1.2V in the documentation rather than a complete removal though.
In any case,
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
On 12/12/2025 22:55, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.
>
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Added only Fixes tag for the initial commit, not all the copy-paste
> propagated ones.
> ---
> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..9009cfe993d75 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index ee35e3bc97ffd..cb922f90fe900 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -129,7 +129,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index c99fe4106eee9..2231d7216f62a 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -268,7 +268,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> index 35c40fe223767..8e6ca94c88695 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> @@ -95,7 +95,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 82bf4689d3300..d50e096b900db 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -211,7 +211,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index ebf68ff4ab961..ccd2d024bfd10 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> @@ -300,7 +300,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
>
> ---
> base-commit: d9771d0dbe18dd643760431870a6abf9b0866bb0
> change-id: 20251212-docs-camss-fixes-0fa525271951
>
> Best regards,
> --
> David Heidelberg <david@ixit.cz>
>
>
>
I think this is copy/paste legacy error.
The voltage level should be more usefully encoded in the name anyway.
---
bod
On 12/12/2025 23:55, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.
>
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Added only Fixes tag for the initial commit, not all the copy-paste
> propagated ones.
> ---
> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..9009cfe993d75 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
If doing this then also drop all redundant useless information. It is
never useful to say that phandle is a phandle and that supply is a
regulator supply, so just "PHY refclk PLL block supply".
Best regards,
Krzysztof
© 2016 - 2025 Red Hat, Inc.