[v1] resource: provide 0args DEFINE_RES variant for unset resource desc

[PATCH] resource: provide 0args DEFINE_RES variant for unset resource desc

Posted by Christian Marangi 5 days, 14 hours ago

Provide a variant of DEFINE_RES that takes 0 arguments to inizialize an
"unset" resource descriptor.

This should be used for the improper case of

	struct resource res = {};

where DEFINE_RES() should be used.

With this new helper variant, it would result in:

	struct resource res = DEFINE_RES();

instead of having to define the full 3 arguments:

	struct resource res = DEFINE_RES(0, 0, IORESOURCE_UNSET);

DEFINE_RES() with no args, will set the flags to IORESOURCE_UNSET
signaling the resource descriptor is UNSET and doesn't reflect an actual
resource currently.

Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 include/linux/ioport.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index d3e837eb8760..ebdbaaf7a520 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -168,8 +168,13 @@ enum {
 
 #define DEFINE_RES_NAMED(_start, _size, _name, _flags)			\
 	DEFINE_RES_NAMED_DESC(_start, _size, _name, _flags, IORES_DESC_NONE)
-#define DEFINE_RES(_start, _size, _flags)				\
+#define __DEFINE_RES0()							\
+	DEFINE_RES_NAMED(0, 0, NULL, IORESOURCE_UNSET)
+#define __DEFINE_RES3(_start, _size, _flags)				\
 	DEFINE_RES_NAMED(_start, _size, NULL, _flags)
+#define DEFINE_RES(...)							\
+	CONCATENATE(__DEFINE_RES, COUNT_ARGS(__VA_ARGS__))		\
+		    (__VA_ARGS__)
 
 #define DEFINE_RES_IO_NAMED(_start, _size, _name)			\
 	DEFINE_RES_NAMED((_start), (_size), (_name), IORESOURCE_IO)
-- 
2.51.0

Re: [PATCH] resource: provide 0args DEFINE_RES variant for unset resource desc

Posted by Andy Shevchenko 5 days, 11 hours ago

On Wed, Dec 10, 2025 at 07:03:07PM +0100, Christian Marangi wrote:
> Provide a variant of DEFINE_RES that takes 0 arguments to inizialize an
> "unset" resource descriptor.
> 
> This should be used for the improper case of
> 
> 	struct resource res = {};
> 
> where DEFINE_RES() should be used.
> 
> With this new helper variant, it would result in:
> 
> 	struct resource res = DEFINE_RES();
> 
> instead of having to define the full 3 arguments:
> 
> 	struct resource res = DEFINE_RES(0, 0, IORESOURCE_UNSET);
> 
> DEFINE_RES() with no args, will set the flags to IORESOURCE_UNSET
> signaling the resource descriptor is UNSET and doesn't reflect an actual
> resource currently.

...

> +#define DEFINE_RES(...)							\
> +	CONCATENATE(__DEFINE_RES, COUNT_ARGS(__VA_ARGS__))		\
> +		    (__VA_ARGS__)
	CONCATENATE(__DEFINE_RES, COUNT_ARGS(__VA_ARGS__))(__VA_ARGS__)

Can be one line. Moreover, it will be even better to show that we imply
a function call here.

And this requires including args.h.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] resource: provide 0args DEFINE_RES variant for unset resource desc

Posted by Bjorn Helgaas 5 days, 11 hours ago

On Wed, Dec 10, 2025 at 07:03:07PM +0100, Christian Marangi wrote:
> Provide a variant of DEFINE_RES that takes 0 arguments to inizialize an
> "unset" resource descriptor.

s/inizialize/initialize/

> This should be used for the improper case of
> 
> 	struct resource res = {};
> 
> where DEFINE_RES() should be used.
> 
> With this new helper variant, it would result in:
> 
> 	struct resource res = DEFINE_RES();
> 
> instead of having to define the full 3 arguments:
> 
> 	struct resource res = DEFINE_RES(0, 0, IORESOURCE_UNSET);
> 
> DEFINE_RES() with no args, will set the flags to IORESOURCE_UNSET
> signaling the resource descriptor is UNSET and doesn't reflect an actual
> resource currently.
> 
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Looks good to me, thanks for doing this!

Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  include/linux/ioport.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index d3e837eb8760..ebdbaaf7a520 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -168,8 +168,13 @@ enum {
>  
>  #define DEFINE_RES_NAMED(_start, _size, _name, _flags)			\
>  	DEFINE_RES_NAMED_DESC(_start, _size, _name, _flags, IORES_DESC_NONE)
> -#define DEFINE_RES(_start, _size, _flags)				\
> +#define __DEFINE_RES0()							\
> +	DEFINE_RES_NAMED(0, 0, NULL, IORESOURCE_UNSET)
> +#define __DEFINE_RES3(_start, _size, _flags)				\
>  	DEFINE_RES_NAMED(_start, _size, NULL, _flags)
> +#define DEFINE_RES(...)							\
> +	CONCATENATE(__DEFINE_RES, COUNT_ARGS(__VA_ARGS__))		\
> +		    (__VA_ARGS__)
>  
>  #define DEFINE_RES_IO_NAMED(_start, _size, _name)			\
>  	DEFINE_RES_NAMED((_start), (_size), (_name), IORESOURCE_IO)
> -- 
> 2.51.0
>