[v1] pinctrl: fix compile test defaults

[PATCH] pinctrl: fix compile test defaults

Posted by Johan Hovold 3 days, 22 hours ago

Enabling compile testing should not enable every individual driver (we
have "allyesconfig" for that) but two new drivers got this wrong.

Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/pinctrl/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bc7f37afc48b..ce5685215b92 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP
 	help
 	  This selects the pinctrl driver for gpio2 on pic64gx.
 
@@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP
 	help
 	  This selects the pinctrl driver for Microchip Polarfire SoC.
 
-- 
2.52.0

Re: [PATCH] pinctrl: fix compile test defaults

Posted by Conor Dooley 3 days, 11 hours ago

On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that) but two new drivers got this wrong.
> 
> Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index bc7f37afc48b..ce5685215b92 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP

Nah, not a fan of this kind of thing, please just make it default n if
this compile test behaviour bothers you.

>  	help
>  	  This selects the pinctrl driver for gpio2 on pic64gx.
>  
> @@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP
>  	help
>  	  This selects the pinctrl driver for Microchip Polarfire SoC.
>  
> -- 
> 2.52.0
>

Re: [PATCH] pinctrl: fix compile test defaults

Posted by Johan Hovold 2 days ago

On Wed, Dec 10, 2025 at 02:22:02PM +0000, Conor Dooley wrote:
> On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> > Enabling compile testing should not enable every individual driver (we
> > have "allyesconfig" for that) but two new drivers got this wrong.
> > 
> > Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> > Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> > Cc: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/pinctrl/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> > index bc7f37afc48b..ce5685215b92 100644
> > --- a/drivers/pinctrl/Kconfig
> > +++ b/drivers/pinctrl/Kconfig
> > @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
> >  	depends on ARCH_MICROCHIP || COMPILE_TEST
> >  	depends on OF
> >  	select GENERIC_PINCONF
> > -	default y
> > +	default ARCH_MICROCHIP
> 
> Nah, not a fan of this kind of thing, please just make it default n if
> this compile test behaviour bothers you.

Sure, I guess that's better here as these drivers are not needed in
every Microchip build either.

Johan