Use LIST_HEAD() to declare and initialize the 'mappings' list head in
iommu_create_device_direct_mappings() instead of separate declaration and
INIT_LIST_HEAD(). This simplifies the code by combining declaration and
initialization into a single idiomatic form, improving readability without
changing functionality.

Signed-off-by: Can Peng <pengcan@kylinos.cn>
---
 drivers/iommu/iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 2ca990dfbb88..77d723f43546 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1173,12 +1173,11 @@ static int iommu_create_device_direct_mappings(struct iommu_domain *domain,
 					       struct device *dev)
 {
 	struct iommu_resv_region *entry;
-	struct list_head mappings;
+	LIST_HEAD(mappings);
 	unsigned long pg_size;
 	int ret = 0;
 
 	pg_size = domain->pgsize_bitmap ? 1UL << __ffs(domain->pgsize_bitmap) : 0;
-	INIT_LIST_HEAD(&mappings);
 
 	if (WARN_ON_ONCE(iommu_is_dma_domain(domain) && !pg_size))
 		return -EINVAL;
-- 
2.25.1

> Use LIST_HEAD() to declare and initialize the 'mappings' list head in
> iommu_create_device_direct_mappings() instead of separate declaration and
> INIT_LIST_HEAD(). This simplifies the code by combining declaration and
> initialization into a single idiomatic form, improving readability without
> changing functionality.
…

How do you think about to repeat the mentioned transformation approach for the implementation
of the function “iommu_group_show_resv_regions”?
https://elixir.bootlin.com/linux/v6.19-rc4/source/drivers/iommu/iommu.c#L949-L969

Regards,
Markus

On Tue, Dec 09, 2025 at 03:15:13PM +0800, Can Peng wrote:
> Use LIST_HEAD() to declare and initialize the 'mappings' list head in
> iommu_create_device_direct_mappings() instead of separate declaration and
> INIT_LIST_HEAD(). This simplifies the code by combining declaration and
> initialization into a single idiomatic form, improving readability without
> changing functionality.
> 
> Signed-off-by: Can Peng <pengcan@kylinos.cn>
> ---
>  drivers/iommu/iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.