arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Many years have passed (more than 9 actually) since the introduction of
the Nexus 5 dts to Linux and it's high time to update the model property
to be a proper model name and thereby bringing it to the standards of
the 2020s.
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
The phone was manufactured by LG and sold by Google. Some sources call
it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
just Nexus 5, but consensus in upstream dts seems to be to use the
manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
Arguments could also easily be made to change the compatible to
"lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
even documented in vendor-prefixes and doesn't really appear anywhere
else in the kernel and lg, (for LG Corporation, the parent of LG
Electronics from what I can tell) is used. But that's more invasive so
I'm leaving this out in favor of this simple patch.
---
arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
index b3127f0383cf..8f4a1fda9276 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
@@ -7,7 +7,7 @@
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
/ {
- model = "LGE MSM 8974 HAMMERHEAD";
+ model = "LG Nexus 5";
compatible = "lge,hammerhead", "qcom,msm8974";
chassis-type = "handset";
---
base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
change-id: 20251208-msm8974-hammerhead-model-fa3aca1fda0e
Best regards,
--
Luca Weiss <luca@lucaweiss.eu>
On 12/8/25 1:41 PM, Luca Weiss wrote: > Many years have passed (more than 9 actually) since the introduction of > the Nexus 5 dts to Linux and it's high time to update the model property > to be a proper model name and thereby bringing it to the standards of > the 2020s. > > Signed-off-by: Luca Weiss <luca@lucaweiss.eu> > --- > The phone was manufactured by LG and sold by Google. Some sources call > it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as > just Nexus 5, but consensus in upstream dts seems to be to use the > manufacturer, see Nexus 5X, Nexus 6P, Nexus 4. > > Arguments could also easily be made to change the compatible to > "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not > even documented in vendor-prefixes and doesn't really appear anywhere > else in the kernel and lg, (for LG Corporation, the parent of LG > Electronics from what I can tell) is used. But that's more invasive so > I'm leaving this out in favor of this simple patch. > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On 08/12/2025 13:41, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
>
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> The phone was manufactured by LG and sold by Google. Some sources call
> it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
> just Nexus 5, but consensus in upstream dts seems to be to use the
> manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
>
> Arguments could also easily be made to change the compatible to
> "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
> even documented in vendor-prefixes and doesn't really appear anywhere
> else in the kernel and lg, (for LG Corporation, the parent of LG
> Electronics from what I can tell) is used. But that's more invasive so
> I'm leaving this out in favor of this simple patch.
> ---
> arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> index b3127f0383cf..8f4a1fda9276 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -7,7 +7,7 @@
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>
> / {
> - model = "LGE MSM 8974 HAMMERHEAD";
> + model = "LG Nexus 5";
> compatible = "lge,hammerhead", "qcom,msm8974";
> chassis-type = "handset";
>
>
> ---
> base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
> change-id: 20251208-msm8974-hammerhead-model-fa3aca1fda0e
>
> Best regards,
Hehe, definitely an improvement.
Reviewed-by: David Heidelberg <david@ixit.cz>
© 2016 - 2025 Red Hat, Inc.