[PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa

Petre Rodan posted 2 patches 1 week, 5 days ago
[PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Posted by Petre Rodan 1 week, 5 days ago
Adds binding for digital Honeywell ABP2 series pressure and temperature
sensors.
The i2c address is hardcoded and depends on the part number.
There is an optional interrupt that signals the end of conversion.

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
    v1->v3 unchanged
    v3->v4 'vdd-supply: true' change requested by Jonathan
---
 .../bindings/iio/pressure/honeywell,abp2030pa.yaml | 132 +++++++++++++++++++++
 MAINTAINERS                                        |   6 +
 2 files changed, 138 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,abp2030pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,abp2030pa.yaml
new file mode 100644
index 000000000000..e82897ffac3b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,abp2030pa.yaml
@@ -0,0 +1,132 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/pressure/honeywell,abp2030pa.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Honeywell abp2030pa pressure sensor
+
+maintainers:
+  - Petre Rodan <petre.rodan@subdimension.ro>
+
+description: |
+  Honeywell pressure sensor of model abp2030pa.
+
+  This sensor has an I2C and SPI interface.
+
+  There are many models with different pressure ranges available. The vendor
+  calls them "ABP2 series". All of them have an identical programming model and
+  differ in the pressure range and measurement unit.
+
+  To support different models one needs to specify its pressure triplet.
+
+  For custom silicon chips not covered by the Honeywell ABP2 series datasheet,
+  the pressure values can be specified manually via honeywell,pmin-pascal and
+  honeywell,pmax-pascal.
+
+  Specifications about the devices can be found at:
+  https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/basic-abp2-series/documents/sps-siot-abp2-series-datasheet-32350268-en.pdf
+
+properties:
+  compatible:
+    const: honeywell,abp2030pa
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description:
+      Optional interrupt for indicating end of conversion.
+      SPI variants of ABP2 chips do not provide this feature.
+    maxItems: 1
+
+  honeywell,pressure-triplet:
+    description: |
+      Case-sensitive five character string that defines pressure range, unit
+      and type as part of the device nomenclature. In the unlikely case of a
+      custom chip, unset and provide pmin-pascal and pmax-pascal instead.
+    enum: [001BA, 1.6BA, 2.5BA, 004BA, 006BA, 008BA, 010BA, 012BA, 001BD,
+           1.6BD, 2.5BD, 004BD, 001BG, 1.6BG, 2.5BG, 004BG, 006BG, 008BG,
+           010BG, 012BG, 001GG, 1.2GG, 100KA, 160KA, 250KA, 001KD, 1.6KD,
+           2.5KD, 004KD, 006KD, 010KD, 016KD, 025KD, 040KD, 060KD, 100KD,
+           160KD, 250KD, 400KD, 001KG, 1.6KG, 2.5KG, 004KG, 006KG, 010KG,
+           016KG, 025KG, 040KG, 060KG, 100KG, 160KG, 250KG, 400KG, 600KG,
+           800KG, 250LD, 600LD, 600LG, 2.5MD, 006MD, 010MD, 016MD, 025MD,
+           040MD, 060MD, 100MD, 160MD, 250MD, 400MD, 600MD, 006MG, 010MG,
+           016MG, 025MG, 040MG, 060MG, 100MG, 160MG, 250MG, 400MG, 600MG,
+           001ND, 002ND, 004ND, 005ND, 010ND, 020ND, 030ND, 002NG, 004NG,
+           005NG, 010NG, 020NG, 030NG, 015PA, 030PA, 060PA, 100PA, 150PA,
+           175PA, 001PD, 005PD, 015PD, 030PD, 060PD, 001PG, 005PG, 015PG,
+           030PG, 060PG, 100PG, 150PG, 175PG]
+    $ref: /schemas/types.yaml#/definitions/string
+
+  honeywell,pmin-pascal:
+    description:
+      Minimum pressure value the sensor can measure in pascal.
+
+  honeywell,pmax-pascal:
+    description:
+      Maximum pressure value the sensor can measure in pascal.
+
+  spi-max-frequency:
+    maximum: 800000
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+oneOf:
+  - required:
+      - honeywell,pressure-triplet
+  - required:
+      - honeywell,pmin-pascal
+      - honeywell,pmax-pascal
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml
+  - if:
+      required:
+        - honeywell,pressure-triplet
+    then:
+      properties:
+        honeywell,pmin-pascal: false
+        honeywell,pmax-pascal: false
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pressure@18 {
+            compatible = "honeywell,abp2030pa";
+            reg = <0x18>;
+            interrupt-parent = <&gpio3>;
+            interrupts = <21 IRQ_TYPE_EDGE_RISING>;
+
+            honeywell,pressure-triplet = "001BA";
+            vdd-supply = <&vcc_3v3>;
+        };
+    };
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pressure@0 {
+            compatible = "honeywell,abp2030pa";
+            reg = <0>;
+            spi-max-frequency = <800000>;
+
+            honeywell,pressure-triplet = "001PD";
+            vdd-supply = <&vcc_3v3>;
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 31d98efb1ad1..15b92300acbc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11404,6 +11404,12 @@ F:	lib/test_hmm*
 F:	mm/hmm*
 F:	tools/testing/selftests/mm/*hmm*
 
+HONEYWELL ABP2030PA PRESSURE SENSOR SERIES IIO DRIVER
+M:	Petre Rodan <petre.rodan@subdimension.ro>
+L:	linux-iio@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/iio/pressure/honeywell,abp2030pa.yaml
+
 HONEYWELL HSC030PA PRESSURE SENSOR SERIES IIO DRIVER
 M:	Petre Rodan <petre.rodan@subdimension.ro>
 L:	linux-iio@vger.kernel.org

-- 
2.51.2
Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Posted by Krzysztof Kozlowski 1 week, 4 days ago
On 07/12/2025 07:00, Petre Rodan wrote:
> Adds binding for digital Honeywell ABP2 series pressure and temperature
> sensors.
> The i2c address is hardcoded and depends on the part number.
> There is an optional interrupt that signals the end of conversion.
> 
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

I will not be doing work twice and, without explanation, forcing me to
do that is disrespectful to my time.

Best regards,
Krzysztof
Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Posted by Petre Rodan 1 week, 4 days ago
hello Krzysztof, 

On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2025 07:00, Petre Rodan wrote:
> > Adds binding for digital Honeywell ABP2 series pressure and temperature
> > sensors.
> > The i2c address is hardcoded and depends on the part number.
> > There is an optional interrupt that signals the end of conversion.
> > 
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

[..]

> If a tag was not added on purpose, please state why and what changed.
> </form letter>

I removed the tag on purpose since the yaml file was modified in v4 as per the
changelog that is below the commit message.

> I will not be doing work twice and, without explanation, forcing me to
> do that is disrespectful to my time.

sorry about that. the single thing that changed was that

---- 8< --------------------------------------------
@@ -76,8 +71,7 @@ properties:
   spi-max-frequency:
     maximum: 800000
 
-  vdd-supply:
-    description: provide VDD power to the sensor.
+  vdd-supply: true
 
 required:
   - compatible
---- >8 --------------------------------------------

I checked the resulting file with make dt_binding_check, yet I was not sure if your previous tag would still validate the work.

best regards,
peter
Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Posted by Krzysztof Kozlowski 1 week, 4 days ago
On 08/12/2025 08:15, Petre Rodan wrote:
> 
> hello Krzysztof, 
> 
> On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
>> On 07/12/2025 07:00, Petre Rodan wrote:
>>> Adds binding for digital Honeywell ABP2 series pressure and temperature
>>> sensors.
>>> The i2c address is hardcoded and depends on the part number.
>>> There is an optional interrupt that signals the end of conversion.
>>>
>>> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
> 
> [..]
> 
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
> 
> I removed the tag on purpose since the yaml file was modified in v4 as per the
> changelog that is below the commit message.

Please read my form letter and please read linked submitting patches
doc. I pointed to a very specific paragraph, so you don't need to read
everything...

> 
>> I will not be doing work twice and, without explanation, forcing me to
>> do that is disrespectful to my time.
> 
> sorry about that. the single thing that changed was that
> 
> ---- 8< --------------------------------------------
> @@ -76,8 +71,7 @@ properties:
>    spi-max-frequency:
>      maximum: 800000
>  
> -  vdd-supply:
> -    description: provide VDD power to the sensor.
> +  vdd-supply: true
>  


This is trivial and absolutely NOT a reason to drop the tag. Did you
read submitting patches document? Please consider TIME of reviewers,
even time spent on replying on this.

Best regards,
Krzysztof
Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Posted by Jonathan Cameron 4 days, 20 hours ago
On Mon, 8 Dec 2025 08:21:49 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 08/12/2025 08:15, Petre Rodan wrote:
> > 
> > hello Krzysztof, 
> > 
> > On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:  
> >> On 07/12/2025 07:00, Petre Rodan wrote:  
> >>> Adds binding for digital Honeywell ABP2 series pressure and temperature
> >>> sensors.
> >>> The i2c address is hardcoded and depends on the part number.
> >>> There is an optional interrupt that signals the end of conversion.
> >>>
> >>> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>  
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It looks like you received a tag and forgot to add it.  
> > 
> > [..]
> >   
> >> If a tag was not added on purpose, please state why and what changed.
> >> </form letter>  
> > 
> > I removed the tag on purpose since the yaml file was modified in v4 as per the
> > changelog that is below the commit message.  
> 
> Please read my form letter and please read linked submitting patches
> doc. I pointed to a very specific paragraph, so you don't need to read
> everything...
> 
> >   
> >> I will not be doing work twice and, without explanation, forcing me to
> >> do that is disrespectful to my time.  
> > 
> > sorry about that. the single thing that changed was that
> > 
> > ---- 8< --------------------------------------------
> > @@ -76,8 +71,7 @@ properties:
> >    spi-max-frequency:
> >      maximum: 800000
> >  
> > -  vdd-supply:
> > -    description: provide VDD power to the sensor.
> > +  vdd-supply: true
> >    
> 
> 
> This is trivial and absolutely NOT a reason to drop the tag. Did you
> read submitting patches document? Please consider TIME of reviewers,
> even time spent on replying on this.

I put the tag back and applied to the testing branch of iio.git.
I'll rebase that on rc1 once it is available.

Thanks,

Jonathan