arch/arm64/boot/dts/mediatek/mt8183.dtsi | 122 +++++++++++++++++++++++++------ 1 file changed, 98 insertions(+), 24 deletions(-)
The endpoint IDs in the display graph are expected to match the
associated display path number, i.e. all endpoints connected to
mmsys_ep_main must have reg = <0> and all endpoints connected to
mmsys_ep_ext must have reg = <1>.
Add the missing ID to all endpoints in the display graph, based on
mt8365.dtsi as an existing example that does this correctly.
Fixes: e72d63fa0563 ("arm64: dts: mediatek: mt8183: Migrate to display controller OF graph")
Reported-by: Evans Jahja <evansjahja13@gmail.com>
Closes: https://lore.kernel.org/linux-mediatek/CAAq5pW9o3itC0G16LnJO7KMAQ_XoqXUpB=cuJ_7e3-H11zKd5Q@mail.gmail.com/
Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 122 +++++++++++++++++++++++++------
1 file changed, 98 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 4e20a8f2eb25803057955401a7737c7f029a1424..0c73043c67fd01147179e8f9b065684f67749ec2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1754,15 +1754,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- ovl0_in: endpoint {
+ ovl0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&mmsys_ep_main>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- ovl0_out: endpoint {
+ ovl0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&ovl_2l0_in>;
};
};
@@ -1783,15 +1789,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- ovl_2l0_in: endpoint {
+ ovl_2l0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&ovl0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- ovl_2l0_out: endpoint {
+ ovl_2l0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&rdma0_in>;
};
};
@@ -1812,15 +1824,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- ovl_2l1_in: endpoint {
+ ovl_2l1_in: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&mmsys_ep_ext>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- ovl_2l1_out: endpoint {
+ ovl_2l1_out: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&rdma1_in>;
};
};
@@ -1842,15 +1860,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- rdma0_in: endpoint {
+ rdma0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&ovl_2l0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- rdma0_out: endpoint {
+ rdma0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&color0_in>;
};
};
@@ -1872,15 +1896,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- rdma1_in: endpoint {
+ rdma1_in: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&ovl_2l1_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- rdma1_out: endpoint {
+ rdma1_out: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&dpi_in>;
};
};
@@ -1901,15 +1931,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- color0_in: endpoint {
+ color0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&rdma0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- color0_out: endpoint {
+ color0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&ccorr0_in>;
};
};
@@ -1929,15 +1965,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- ccorr0_in: endpoint {
+ ccorr0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&color0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- ccorr0_out: endpoint {
+ ccorr0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&aal0_in>;
};
};
@@ -1957,15 +1999,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- aal0_in: endpoint {
+ aal0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&ccorr0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- aal0_out: endpoint {
+ aal0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&gamma0_in>;
};
};
@@ -1985,15 +2033,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- gamma0_in: endpoint {
+ gamma0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&aal0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- gamma0_out: endpoint {
+ gamma0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&dither0_in>;
};
};
@@ -2013,15 +2067,21 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- dither0_in: endpoint {
+ dither0_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&gamma0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- dither0_out: endpoint {
+ dither0_out: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&dsi_in>;
};
};
@@ -2047,15 +2107,22 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- dsi_in: endpoint {
+ dsi_in: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&dither0_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- dsi_out: endpoint { };
+ dsi_out: endpoint@0 {
+ reg = <0>;
+ };
};
};
};
@@ -2076,15 +2143,22 @@ ports {
#size-cells = <0>;
port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- dpi_in: endpoint {
+ dpi_in: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&rdma1_out>;
};
};
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- dpi_out: endpoint { };
+ dpi_out: endpoint@1 {
+ reg = <1>;
+ };
};
};
};
---
base-commit: 6987d58a9cbc5bd57c983baa514474a86c945d56
change-id: 20251206-mt8183-display-graph-506183c68b3b
Best regards,
--
Otto Pflüger <otto.pflueger@abscue.de>
On Sun, Dec 7, 2025 at 1:54 AM Otto Pflüger <otto.pflueger@abscue.de> wrote:
>
> The endpoint IDs in the display graph are expected to match the
> associated display path number, i.e. all endpoints connected to
> mmsys_ep_main must have reg = <0> and all endpoints connected to
> mmsys_ep_ext must have reg = <1>.
>
> Add the missing ID to all endpoints in the display graph, based on
> mt8365.dtsi as an existing example that does this correctly.
>
> Fixes: e72d63fa0563 ("arm64: dts: mediatek: mt8183: Migrate to display controller OF graph")
> Reported-by: Evans Jahja <evansjahja13@gmail.com>
> Closes: https://lore.kernel.org/linux-mediatek/CAAq5pW9o3itC0G16LnJO7KMAQ_XoqXUpB=cuJ_7e3-H11zKd5Q@mail.gmail.com/
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Restores the display on my MT8183 Juniper device to normal.
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 122 +++++++++++++++++++++++++------
> 1 file changed, 98 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 4e20a8f2eb25803057955401a7737c7f029a1424..0c73043c67fd01147179e8f9b065684f67749ec2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1754,15 +1754,21 @@ ports {
> #size-cells = <0>;
>
> port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0>;
"reg" (and "compatible") properties should come before all other ones,
as documented in the device tree coding style. This applies to all the
additions in this patch.
ChenYu
© 2016 - 2026 Red Hat, Inc.