Drop the spurios "space" character in Makefile condition check
that causes mshv_common.o to be built regardless of the CONFIG settings.

Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Suggested-by: Michael Kelley <mhklinux@outlook.com>
---
 drivers/hv/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
index 58b8d07639f3..6d929fb0e13d 100644
--- a/drivers/hv/Makefile
+++ b/drivers/hv/Makefile
@@ -20,6 +20,6 @@ mshv_vtl-y := mshv_vtl_main.o
 # Code that must be built-in
 obj-$(CONFIG_HYPERV) += hv_common.o
 obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
-ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
+ifneq ($(CONFIG_MSHV_ROOT)$(CONFIG_MSHV_VTL),)
 	obj-y += mshv_common.o
 endif
-- 
2.51.0

Please provide a proper commit subject.

On Fri, Dec 05, 2025 at 02:17:05PM -0600, Praveen K Paladugu wrote:
> Drop the spurios "space" character in Makefile condition check
> that causes mshv_common.o to be built regardless of the CONFIG settings.
> 
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> Suggested-by: Michael Kelley <mhklinux@outlook.com>

This should come with a Fixes: tag.

> ---
>  drivers/hv/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> index 58b8d07639f3..6d929fb0e13d 100644
> --- a/drivers/hv/Makefile
> +++ b/drivers/hv/Makefile
> @@ -20,6 +20,6 @@ mshv_vtl-y := mshv_vtl_main.o
>  # Code that must be built-in
>  obj-$(CONFIG_HYPERV) += hv_common.o
>  obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
> -ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
> +ifneq ($(CONFIG_MSHV_ROOT)$(CONFIG_MSHV_VTL),)
>  	obj-y += mshv_common.o
>  endif
> -- 
> 2.51.0
>

On Fri, Dec 05, 2025 at 11:06:24PM +0000, Wei Liu wrote:
> Please provide a proper commit subject.
> 
> On Fri, Dec 05, 2025 at 02:17:05PM -0600, Praveen K Paladugu wrote:
> > Drop the spurios "space" character in Makefile condition check
> > that causes mshv_common.o to be built regardless of the CONFIG settings.
> > 
> > Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> > Suggested-by: Michael Kelley <mhklinux@outlook.com>
> 
> This should come with a Fixes: tag.

Since the bug is not in any released kernel, so it is not needed.

I don't want to squash this though. So the request to have a proper
subject line still stands.

Wei

> 
> > ---
> >  drivers/hv/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> > index 58b8d07639f3..6d929fb0e13d 100644
> > --- a/drivers/hv/Makefile
> > +++ b/drivers/hv/Makefile
> > @@ -20,6 +20,6 @@ mshv_vtl-y := mshv_vtl_main.o
> >  # Code that must be built-in
> >  obj-$(CONFIG_HYPERV) += hv_common.o
> >  obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
> > -ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
> > +ifneq ($(CONFIG_MSHV_ROOT)$(CONFIG_MSHV_VTL),)
> >  	obj-y += mshv_common.o
> >  endif
> > -- 
> > 2.51.0
> >

On Fri, Dec 05, 2025 at 11:08:06PM +0000, Wei Liu wrote:
> On Fri, Dec 05, 2025 at 11:06:24PM +0000, Wei Liu wrote:
> > Please provide a proper commit subject.
> > 
> > On Fri, Dec 05, 2025 at 02:17:05PM -0600, Praveen K Paladugu wrote:
> > > Drop the spurios "space" character in Makefile condition check
> > > that causes mshv_common.o to be built regardless of the CONFIG settings.
> > > 
> > > Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> > > Suggested-by: Michael Kelley <mhklinux@outlook.com>
> > 
> > This should come with a Fixes: tag.
> 
> Since the bug is not in any released kernel, so it is not needed.
> 
> I don't want to squash this though. So the request to have a proper
> subject line still stands.

Never mind. I can fix this myself. There is no need to have another
round.

Wei