tools/testing/ktest/config-bisect.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Linus,
ktest: Fix for v6.19:
- Fix incorrect variable in error message in config-bisect.pl
If the old config file fails to get copied as the last good or bad
config file, then it fails the program and prints an error message.
But the variable used to print what the old config's name was incorrect.
It was $config when it should have been $output_config.
Please pull the latest ktest-v6.19 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git
ktest-v6.19
Tag SHA1: 896fb88396c2dd1074782e89d84a70a6f9940765
Head SHA1: d3042cbe84a060b4df764eb6c5300bbe20d125ca
Steven Rostedt (1):
ktest.pl: Fix uninitialized var in config-bisect.pl
----
tools/testing/ktest/config-bisect.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---------------------------
commit d3042cbe84a060b4df764eb6c5300bbe20d125ca
Author: Steven Rostedt <rostedt@goodmis.org>
Date: Wed Dec 3 18:09:24 2025 -0500
ktest.pl: Fix uninitialized var in config-bisect.pl
The error path of copying the old config used the wrong variable in the
error message:
$ mkdir /tmp/build
$ ./tools/testing/ktest/config-bisect.pl -b /tmp/build config-good /tmp/config-bad
$ chmod 0 /tmp/build
$ ./tools/testing/ktest/config-bisect.pl -b /tmp/build config-good /tmp/config-bad good
cp /tmp/build//.config config-good.tmp ... [0 seconds] FAILED!
Use of uninitialized value $config in concatenation (.) or string at ./tools/testing/ktest/config-bisect.pl line 744.
failed to copy to config-good.tmp
When it should have shown:
failed to copy /tmp/build//.config to config-good.tmp
Cc: stable@vger.kernel.org
Cc: John 'Warthog9' Hawley <warthog9@kernel.org>
Fixes: 0f0db065999cf ("ktest: Add standalone config-bisect.pl program")
Link: https://patch.msgid.link/20251203180924.6862bd26@gandalf.local.home
Reported-by: "John W. Krahn" <jwkrahn@shaw.ca>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/tools/testing/ktest/config-bisect.pl b/tools/testing/ktest/config-bisect.pl
index 6fd864935319..bee7cb34a289 100755
--- a/tools/testing/ktest/config-bisect.pl
+++ b/tools/testing/ktest/config-bisect.pl
@@ -741,9 +741,9 @@ if ($start) {
die "Can not find file $bad\n";
}
if ($val eq "good") {
- run_command "cp $output_config $good" or die "failed to copy $config to $good\n";
+ run_command "cp $output_config $good" or die "failed to copy $output_config to $good\n";
} elsif ($val eq "bad") {
- run_command "cp $output_config $bad" or die "failed to copy $config to $bad\n";
+ run_command "cp $output_config $bad" or die "failed to copy $output_config to $bad\n";
}
}
The pull request you sent on Fri, 5 Dec 2025 10:26:35 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git ktest-v6.19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2e8c1c6a5043999d867d0dcf38be96903c99601a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
The pull request you sent on Fri, 5 Dec 2025 10:26:35 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git ktest-v6.19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2e8c1c6a5043999d867d0dcf38be96903c99601a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
© 2016 - 2025 Red Hat, Inc.