[PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency

Arnd Bergmann posted 1 patch 2 weeks ago
drivers/gpio/Kconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency
Posted by Arnd Bergmann 2 weeks ago
From: Arnd Bergmann <arnd@arndb.de>

Selecting OF_GPIO is generally not allowed, it always gets enabled
when both GPIOLIB and OF are turned on.

The tb10x driver now warns about this after it was enabled for
compile-testing:

WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])

OF_GPIO is not required for compile-testing and is already enabled
when the driver is usable, so just drop the 'select' line.

Fixes: 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 02099ef48f22..e9dc19ce3545 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -737,7 +737,6 @@ config GPIO_TB10X
 	depends on ARC_PLAT_TB10X || COMPILE_TEST
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
-	select OF_GPIO
 
 config GPIO_TEGRA
 	tristate "NVIDIA Tegra GPIO support"
-- 
2.39.5
Re: [PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency
Posted by Bartosz Golaszewski 1 week, 6 days ago
On Fri, 05 Dec 2025 10:54:09 +0100, Arnd Bergmann wrote:
> Selecting OF_GPIO is generally not allowed, it always gets enabled
> when both GPIOLIB and OF are turned on.
> 
> The tb10x driver now warns about this after it was enabled for
> compile-testing:
> 
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
> 
> [...]

Applied, thanks!

[1/1] gpio: tb10x: fix OF_GPIO dependency
      https://git.kernel.org/brgl/linux/c/a0cf7d69016e1917c2ac284840254b5f1dd75e23

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>