[PATCH 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable error

Guenter Roeck posted 13 patches 2 months ago
[PATCH 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable error
Posted by Guenter Roeck 2 months ago
Building netlink-dumps with -Werror results in

netlink-dumps.c: In function ‘dump_extack’:
../kselftest_harness.h:788:35: error: ‘ret’ may be used uninitialized

Problem is that the loop which initializes 'ret' may exit early without
initializing the variable if recv() returns an error. Always initialize
'ret' to solve the problem.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 tools/testing/selftests/net/netlink-dumps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/netlink-dumps.c b/tools/testing/selftests/net/netlink-dumps.c
index 7618ebe528a4..f4fc0c9910f2 100644
--- a/tools/testing/selftests/net/netlink-dumps.c
+++ b/tools/testing/selftests/net/netlink-dumps.c
@@ -112,7 +112,7 @@ static const struct {
 TEST(dump_extack)
 {
 	int netlink_sock;
-	int i, cnt, ret;
+	int i, cnt, ret = FOUND_ERR;
 	char buf[8192];
 	int one = 1;
 	ssize_t n;
-- 
2.43.0