1. Patchew
  2. linux
  3. [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible
  4. View patch

[PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property

Miaoqing Pan posted 2 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Miaoqing Pan 2 months, 1 week ago 
The firmware-name property was introduced to allow end-users and
integrators to select usecase specific firmware for the WCN6855.
However, specifying firmware for an M.2 WLAN module in the Device
Tree is not appropriate. Instead, this functionality will be handled
within the ath11k driver.

Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
---
 .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
index e34d42a30192..0162e365798b 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
@@ -37,6 +37,7 @@ properties:
 
   firmware-name:
     maxItems: 1
+    deprecated: true
     description:
       If present, a board or platform specific string used to lookup
       usecase-specific firmware files for the device.
-- 
2.34.1
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Jeff Johnson 2 months ago 
On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
> The firmware-name property was introduced to allow end-users and
> integrators to select usecase specific firmware for the WCN6855.
> However, specifying firmware for an M.2 WLAN module in the Device
> Tree is not appropriate. Instead, this functionality will be handled
> within the ath11k driver.
> 
> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> index e34d42a30192..0162e365798b 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> @@ -37,6 +37,7 @@ properties:
>  
>    firmware-name:
>      maxItems: 1
> +    deprecated: true
>      description:
>        If present, a board or platform specific string used to lookup
>        usecase-specific firmware files for the device.

The driver patch completely removes support for this, so is this really
considered deprecated? Or should this actually be considered obsolete and
completely removed?

Do any DTS files actually reference this?

/jeff
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Miaoqing Pan 1 month, 3 weeks ago 

On 12/12/2025 12:44 AM, Jeff Johnson wrote:
> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>> The firmware-name property was introduced to allow end-users and
>> integrators to select usecase specific firmware for the WCN6855.
>> However, specifying firmware for an M.2 WLAN module in the Device
>> Tree is not appropriate. Instead, this functionality will be handled
>> within the ath11k driver.
>>
>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
>> ---
>>   .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> index e34d42a30192..0162e365798b 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> @@ -37,6 +37,7 @@ properties:
>>   
>>     firmware-name:
>>       maxItems: 1
>> +    deprecated: true
>>       description:
>>         If present, a board or platform specific string used to lookup
>>         usecase-specific firmware files for the device.
> 
> The driver patch completely removes support for this, so is this really
> considered deprecated? Or should this actually be considered obsolete and
> completely removed?
> 
> Do any DTS files actually reference this?
> 
> /jeff

You are correct — since the driver has already removed all support for
`firmware-name`, marking it as `deprecated` is misleading. The proper
status should be `obsolete`, and the binding should reflect that this
property is no longer supported. Regarding DTS usage: no upstream Device 
Tree files currently reference `firmware-name`.
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Krzysztof Kozlowski 1 month, 4 weeks ago 
On 11/12/2025 17:44, Jeff Johnson wrote:
> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>> The firmware-name property was introduced to allow end-users and
>> integrators to select usecase specific firmware for the WCN6855.
>> However, specifying firmware for an M.2 WLAN module in the Device
>> Tree is not appropriate. Instead, this functionality will be handled
>> within the ath11k driver.
>>
>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
>> ---
>>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> index e34d42a30192..0162e365798b 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> @@ -37,6 +37,7 @@ properties:
>>  
>>    firmware-name:
>>      maxItems: 1
>> +    deprecated: true
>>      description:
>>        If present, a board or platform specific string used to lookup
>>        usecase-specific firmware files for the device.
> 
> The driver patch completely removes support for this, so is this really
> considered deprecated? Or should this actually be considered obsolete and

That's silent ABI break. I will formally NAK the patch.


> completely removed?
> 
> Do any DTS files actually reference this?
> 
> /jeff


Best regards,
Krzysztof
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Jeff Johnson 4 weeks ago 
On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote:
> On 11/12/2025 17:44, Jeff Johnson wrote:
>> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>>> The firmware-name property was introduced to allow end-users and
>>> integrators to select usecase specific firmware for the WCN6855.
>>> However, specifying firmware for an M.2 WLAN module in the Device
>>> Tree is not appropriate. Instead, this functionality will be handled
>>> within the ath11k driver.
>>>
>>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
>>> ---
>>>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>> index e34d42a30192..0162e365798b 100644
>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>> @@ -37,6 +37,7 @@ properties:
>>>  
>>>    firmware-name:
>>>      maxItems: 1
>>> +    deprecated: true
>>>      description:
>>>        If present, a board or platform specific string used to lookup
>>>        usecase-specific firmware files for the device.
>>
>> The driver patch completely removes support for this, so is this really
>> considered deprecated? Or should this actually be considered obsolete and
> 
> That's silent ABI break. I will formally NAK the patch.
> 
> 
>> completely removed?
>>
>> Do any DTS files actually reference this?
>>
>> /jeff
> 
> 
> Best regards,
> Krzysztof

Krzysztof,
Can you check the v2 to see if you still want to NAK?

https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com

Thanks,
/jeff
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago 
On 12/01/2026 20:51, Jeff Johnson wrote:
> On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote:
>> On 11/12/2025 17:44, Jeff Johnson wrote:
>>> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>>>> The firmware-name property was introduced to allow end-users and
>>>> integrators to select usecase specific firmware for the WCN6855.
>>>> However, specifying firmware for an M.2 WLAN module in the Device
>>>> Tree is not appropriate. Instead, this functionality will be handled
>>>> within the ath11k driver.
>>>>
>>>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
>>>> ---
>>>>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> index e34d42a30192..0162e365798b 100644
>>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> @@ -37,6 +37,7 @@ properties:
>>>>  
>>>>    firmware-name:
>>>>      maxItems: 1
>>>> +    deprecated: true
>>>>      description:
>>>>        If present, a board or platform specific string used to lookup
>>>>        usecase-specific firmware files for the device.
>>>
>>> The driver patch completely removes support for this, so is this really
>>> considered deprecated? Or should this actually be considered obsolete and
>>
>> That's silent ABI break. I will formally NAK the patch.
>>
>>
>>> completely removed?
>>>
>>> Do any DTS files actually reference this?
>>>
>>> /jeff
>>
>>
>> Best regards,
>> Krzysztof
> 
> Krzysztof,
> Can you check the v2 to see if you still want to NAK?
> 
> https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com
> 

First, yes, still NAK.

Second, that patch faked Rob's tag, so it is unacceptable!

Best regards,
Krzysztof
Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Posted by Rob Herring (Arm) 2 months ago 
On Thu, 04 Dec 2025 15:11:00 +0800, Miaoqing Pan wrote:
> The firmware-name property was introduced to allow end-users and
> integrators to select usecase specific firmware for the WCN6855.
> However, specifying firmware for an M.2 WLAN module in the Device
> Tree is not appropriate. Instead, this functionality will be handled
> within the ath11k driver.
> 
> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.