[v3] atm: mpoa: Fix UAF on qos_head list in procfs

[PATCH net v3 0/1] atm: mpoa: Fix UAF on qos_head list in procfs

Posted by Minseong Kim 2 weeks, 1 day ago

Changes since v2:
  - Replace atm_mpoa_search_qos() with atm_mpoa_get_qos() to avoid
    returning an unprotected pointer.
  - Add atm_mpoa_delete_qos_by_ip() so search+unlink+free is atomic
    under qos_mutex, preventing double-free/UAF.
  - Update all callers accordingly.

Minseong Kim (1):
  atm: mpoa: Fix UAF on qos_head list in procfs

 net/atm/mpc.c         | 184 ++++++++++++++++++++++++++++++++----------
 net/atm/mpc.h         |   3 +-
 net/atm/mpoa_caches.c |  17 ++--
 net/atm/mpoa_proc.c   |   2 +-
 4 files changed, 149 insertions(+), 57 deletions(-)

-- 
2.39.5 (Apple Git-154)

Re: [PATCH net v3 0/1] atm: mpoa: Fix UAF on qos_head list in procfs

Posted by Simon Horman 2 weeks, 1 day ago

On Thu, Dec 04, 2025 at 03:24:20PM +0900, Minseong Kim wrote:
> Changes since v2:
>   - Replace atm_mpoa_search_qos() with atm_mpoa_get_qos() to avoid
>     returning an unprotected pointer.
>   - Add atm_mpoa_delete_qos_by_ip() so search+unlink+free is atomic
>     under qos_mutex, preventing double-free/UAF.
>   - Update all callers accordingly.
> 
> Minseong Kim (1):
>   atm: mpoa: Fix UAF on qos_head list in procfs

Please slow down a bit and allow at least 24h between posting
updated patches. This is to allow time for review to occur.
And reduce load on shared CI infrastructure.

Please see: https://docs.kernel.org/process/maintainer-netdev.html

Re: [PATCH net v3 0/1] atm: mpoa: Fix UAF on qos_head list in procfs

Posted by Minseong Kim 2 weeks, 1 day ago

Hi Simon,

Thanks for the reminder, and sorry for the quick repost.
I understand the 24h minimum interval rule and will follow it for
future revisions.

Best regards,
Minseong Kim

2025년 12월 4일 (목) PM 10:28, Simon Horman <horms@kernel.org>님이 작성:
>
> On Thu, Dec 04, 2025 at 03:24:20PM +0900, Minseong Kim wrote:
> > Changes since v2:
> >   - Replace atm_mpoa_search_qos() with atm_mpoa_get_qos() to avoid
> >     returning an unprotected pointer.
> >   - Add atm_mpoa_delete_qos_by_ip() so search+unlink+free is atomic
> >     under qos_mutex, preventing double-free/UAF.
> >   - Update all callers accordingly.
> >
> > Minseong Kim (1):
> >   atm: mpoa: Fix UAF on qos_head list in procfs
>
> Please slow down a bit and allow at least 24h between posting
> updated patches. This is to allow time for review to occur.
> And reduce load on shared CI infrastructure.
>
> Please see: https://docs.kernel.org/process/maintainer-netdev.html