rust/kernel/num/bounded.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Fix several typos and grammatical errors in the Bounded type documentation:
- "less significant bits" -> "least significant bits"
- "with in" -> "within"
- "withheld" -> "upheld"
- "// This" -> "// This" (double space)
- "doesn't fits" -> "doesn't fit" (2 occurrences)
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1210
Link: https://github.com/Rust-for-Linux/linux/issues/1210
Signed-off-by: Nakamura Shuta <nakamura.shuta@gmail.com>
---
rust/kernel/num/bounded.rs | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/rust/kernel/num/bounded.rs b/rust/kernel/num/bounded.rs
index f870080af..c3ee79ba9 100644
--- a/rust/kernel/num/bounded.rs
+++ b/rust/kernel/num/bounded.rs
@@ -40,11 +40,11 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
fits_within!(value, T, num_bits)
}
-/// An integer value that requires only the `N` less significant bits of the wrapped type to be
+/// An integer value that requires only the `N` least significant bits of the wrapped type to be
/// encoded.
///
/// This limits the number of usable bits in the wrapped integer type, and thus the stored value to
-/// a narrower range, which provides guarantees that can be useful when working with in e.g.
+/// a narrower range, which provides guarantees that can be useful when working within e.g.
/// bitfields.
///
/// # Invariants
@@ -56,7 +56,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
/// # Examples
///
/// The preferred way to create values is through constants and the [`Bounded::new`] family of
-/// constructors, as they trigger a build error if the type invariants cannot be withheld.
+/// constructors, as they trigger a build error if the type invariants cannot be upheld.
///
/// ```
/// use kernel::num::Bounded;
@@ -82,7 +82,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
/// ```
/// use kernel::num::Bounded;
///
-/// // This succeeds because `15` can be represented with 4 unsigned bits.
+/// // This succeeds because `15` can be represented with 4 unsigned bits.
/// assert!(Bounded::<u8, 4>::try_new(15).is_some());
///
/// // This fails because `16` cannot be represented with 4 unsigned bits.
@@ -221,7 +221,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
/// let v: Option<Bounded<u16, 8>> = 128u32.try_into_bounded();
/// assert_eq!(v.as_deref().copied(), Some(128));
///
-/// // Fails because `128` doesn't fits into 6 bits.
+/// // Fails because `128` doesn't fit into 6 bits.
/// let v: Option<Bounded<u16, 6>> = 128u32.try_into_bounded();
/// assert_eq!(v, None);
/// ```
@@ -501,7 +501,7 @@ fn deref(&self) -> &Self::Target {
/// let v: Option<Bounded<u16, 8>> = 128u32.try_into_bounded();
/// assert_eq!(v.as_deref().copied(), Some(128));
///
-/// // Fails because `128` doesn't fits into 6 bits.
+/// // Fails because `128` doesn't fit into 6 bits.
/// let v: Option<Bounded<u16, 6>> = 128u32.try_into_bounded();
/// assert_eq!(v, None);
/// ```
--
2.51.0
On Thu, Dec 04, 2025 at 11:43:36AM +0900, Nakamura Shuta wrote:
> Fix several typos and grammatical errors in the Bounded type documentation:
> - "less significant bits" -> "least significant bits"
> - "with in" -> "within"
> - "withheld" -> "upheld"
> - "// This" -> "// This" (double space)
> - "doesn't fits" -> "doesn't fit" (2 occurrences)
>
> Reported-by: Miguel Ojeda <ojeda@kernel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1210
> Link: https://github.com/Rust-for-Linux/linux/issues/1210
This prints the same link twice... Does that worth it?
Regardless,
Acked-by: Yury Norov (NVIDIA) <yury.norov@nvidia.com>
> Signed-off-by: Nakamura Shuta <nakamura.shuta@gmail.com>
> ---
> rust/kernel/num/bounded.rs | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/rust/kernel/num/bounded.rs b/rust/kernel/num/bounded.rs
> index f870080af..c3ee79ba9 100644
> --- a/rust/kernel/num/bounded.rs
> +++ b/rust/kernel/num/bounded.rs
> @@ -40,11 +40,11 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
> fits_within!(value, T, num_bits)
> }
>
> -/// An integer value that requires only the `N` less significant bits of the wrapped type to be
> +/// An integer value that requires only the `N` least significant bits of the wrapped type to be
> /// encoded.
> ///
> /// This limits the number of usable bits in the wrapped integer type, and thus the stored value to
> -/// a narrower range, which provides guarantees that can be useful when working with in e.g.
> +/// a narrower range, which provides guarantees that can be useful when working within e.g.
> /// bitfields.
> ///
> /// # Invariants
> @@ -56,7 +56,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
> /// # Examples
> ///
> /// The preferred way to create values is through constants and the [`Bounded::new`] family of
> -/// constructors, as they trigger a build error if the type invariants cannot be withheld.
> +/// constructors, as they trigger a build error if the type invariants cannot be upheld.
> ///
> /// ```
> /// use kernel::num::Bounded;
> @@ -82,7 +82,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
> /// ```
> /// use kernel::num::Bounded;
> ///
> -/// // This succeeds because `15` can be represented with 4 unsigned bits.
> +/// // This succeeds because `15` can be represented with 4 unsigned bits.
> /// assert!(Bounded::<u8, 4>::try_new(15).is_some());
> ///
> /// // This fails because `16` cannot be represented with 4 unsigned bits.
> @@ -221,7 +221,7 @@ fn fits_within<T: Integer>(value: T, num_bits: u32) -> bool {
> /// let v: Option<Bounded<u16, 8>> = 128u32.try_into_bounded();
> /// assert_eq!(v.as_deref().copied(), Some(128));
> ///
> -/// // Fails because `128` doesn't fits into 6 bits.
> +/// // Fails because `128` doesn't fit into 6 bits.
> /// let v: Option<Bounded<u16, 6>> = 128u32.try_into_bounded();
> /// assert_eq!(v, None);
> /// ```
> @@ -501,7 +501,7 @@ fn deref(&self) -> &Self::Target {
> /// let v: Option<Bounded<u16, 8>> = 128u32.try_into_bounded();
> /// assert_eq!(v.as_deref().copied(), Some(128));
> ///
> -/// // Fails because `128` doesn't fits into 6 bits.
> +/// // Fails because `128` doesn't fit into 6 bits.
> /// let v: Option<Bounded<u16, 6>> = 128u32.try_into_bounded();
> /// assert_eq!(v, None);
> /// ```
> --
> 2.51.0
> This prints the same link twice... Does that worth it? Good point. Closes alone was enough here. I'll keep this in mind for future patches. Thanks!
On Thu Dec 4, 2025 at 11:43 AM JST, Nakamura Shuta wrote: > Fix several typos and grammatical errors in the Bounded type documentation: > - "less significant bits" -> "least significant bits" > - "with in" -> "within" > - "withheld" -> "upheld" > - "// This" -> "// This" (double space) > - "doesn't fits" -> "doesn't fit" (2 occurrences) > > Reported-by: Miguel Ojeda <ojeda@kernel.org> > Closes: https://github.com/Rust-for-Linux/linux/issues/1210 > Link: https://github.com/Rust-for-Linux/linux/issues/1210 > Signed-off-by: Nakamura Shuta <nakamura.shuta@gmail.com> Thanks! Acked-by: Alexandre Courbot <acourbot@nvidia.com>
© 2016 - 2026 Red Hat, Inc.