[PATCH v4] arm64: qcom: sdm845-oneplus-enchilada: Specify panel name within the compatible

David Heidelberg via B4 Relay posted 1 patch 2 weeks, 1 day ago
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH v4] arm64: qcom: sdm845-oneplus-enchilada: Specify panel name within the compatible
Posted by David Heidelberg via B4 Relay 2 weeks, 1 day ago
From: David Heidelberg <david@ixit.cz>

sofef00 is name of the DDIC, it doesn't contain name of the panel used.
The DDIC is also paired with other panels, so make clear which panel is
used.

New device-tree will work with old driver as expected, due to secondary
compatible.

cosmetic: sort the node.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
This DDIC is essential for panels used in OnePlus 6 and Pixel 3a XL
(SDC variant). With proper support, all downstream patches in
sdm845-mainline and sdm670-mainline can be dropped.

The mainline driver was broken so far, and with my recent introduction
of S6E3FC2X01 driver, I had to "break it even more" due to OnePlus 6
common device-tree changes which defined all the regulators and
corrected properties.

At this moment the first version of the patchset will not include
Pixel 3a XL (SDC) as no testers yet volunteered.

The code, including the Pixel 3a XL enhancement can be found at
  https://gitlab.com/sdm845/sdm845-next/-/commits/b4%252Fsofef00-rebuild
---
Changes in v4:
- adjust commit msg s/enchilada/enchilada-oneplus/
- no code changes, just resend as all other commits got reviewed and merged in -next.
- Link to v3: https://lore.kernel.org/r/20251119-sofef00-rebuild-v3-0-6cd55471e84e@ixit.cz

Changes in v3:
- Drop arch prefix from the commit. (Bjorn)
- Added Casey into MAINTAINERS file. (Casey)
- Moved compatible legacy comment inline.
- Link to v2: https://lore.kernel.org/r/20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz

Changes in v2:
- General fixes to device-tree binding (Krzysztof)
- Add myself as a maintainer
- Updated commits wording
- Link to v1: https://lore.kernel.org/r/20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
index a259eb9d45ae0..8aead6dc25e00 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
@@ -31,9 +31,9 @@ battery: battery {
 };
 
 &display_panel {
-	status = "okay";
+	compatible = "samsung,sofef00-ams628nw01", "samsung,sofef00";
 
-	compatible = "samsung,sofef00";
+	status = "okay";
 };
 
 &bq27441_fg {

---
base-commit: bc04acf4aeca588496124a6cf54bfce3db327039
change-id: 20251104-sofef00-rebuild-04cfc6e68e71

Best regards,
-- 
David Heidelberg <david@ixit.cz>
Re: [PATCH v4] arm64: qcom: sdm845-oneplus-enchilada: Specify panel name within the compatible
Posted by Bjorn Andersson 1 week, 6 days ago
On Thu, 04 Dec 2025 11:41:24 +0100, David Heidelberg wrote:
> sofef00 is name of the DDIC, it doesn't contain name of the panel used.
> The DDIC is also paired with other panels, so make clear which panel is
> used.
> 
> New device-tree will work with old driver as expected, due to secondary
> compatible.
> 
> [...]

Applied, thanks!

[1/1] arm64: qcom: sdm845-oneplus-enchilada: Specify panel name within the compatible
      commit: d60e51cbae7e92c4a00cddb2750129094760da60

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH v4] arm64: qcom: sdm845-oneplus-enchilada: Specify panel name within the compatible
Posted by Dmitry Baryshkov 1 week, 6 days ago
On Thu, Dec 04, 2025 at 11:41:24AM +0100, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> sofef00 is name of the DDIC, it doesn't contain name of the panel used.
> The DDIC is also paired with other panels, so make clear which panel is
> used.
> 
> New device-tree will work with old driver as expected, due to secondary
> compatible.
> 
> cosmetic: sort the node.
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> This DDIC is essential for panels used in OnePlus 6 and Pixel 3a XL
> (SDC variant). With proper support, all downstream patches in
> sdm845-mainline and sdm670-mainline can be dropped.
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry