[PATCH 2/2] perf test: Add missing newlines in debug messages

James Clark posted 2 patches 2 weeks, 1 day ago
[PATCH 2/2] perf test: Add missing newlines in debug messages
Posted by James Clark 2 weeks, 1 day ago
These debug messages bleed into the next log line. Fix it by adding the
missing newlines.

Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/tests/parse-events.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 128d21dc389f..62aa40d8114a 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -2627,7 +2627,7 @@ static int test_events(const struct evlist_test *events, int cnt)
 		pr_debug("running test %d '%s'\n", i, e.name);
 		test_ret = test_event(&e);
 		if (test_ret != TEST_OK) {
-			pr_debug("Event test failure: test %d '%s'", i, e.name);
+			pr_debug("Event test failure: test %d '%s'\n", i, e.name);
 			ret = combine_test_results(ret, test_ret);
 		}
 	}
@@ -2764,7 +2764,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
 
 			test_ret = test_event(&e);
 			if (test_ret != TEST_OK) {
-				pr_debug("Test PMU event failed for '%s'", name);
+				pr_debug("Test PMU event failed for '%s'\n", name);
 				ret = combine_test_results(ret, test_ret);
 			}
 
@@ -2790,7 +2790,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
 			e.check = test__checkevent_pmu_events_mix;
 			test_ret = test_event(&e);
 			if (test_ret != TEST_OK) {
-				pr_debug("Test PMU event failed for '%s'", name);
+				pr_debug("Test PMU event failed for '%s'\n", name);
 				ret = combine_test_results(ret, test_ret);
 			}
 		}

-- 
2.34.1
Re: [PATCH 2/2] perf test: Add missing newlines in debug messages
Posted by Ian Rogers 2 weeks, 1 day ago
On Thu, Dec 4, 2025 at 1:11 AM James Clark <james.clark@linaro.org> wrote:
>
> These debug messages bleed into the next log line. Fix it by adding the
> missing newlines.
>
> Signed-off-by: James Clark <james.clark@linaro.org>

Reviewed-by: Ian Rogers <irogers@google.com>

I looked at the Fixes tag situation but there are a few different
patches that did this wrong. Given this is debug messages in a test,
backporting is a huge priority.

Thanks!
Ian

> ---
>  tools/perf/tests/parse-events.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index 128d21dc389f..62aa40d8114a 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -2627,7 +2627,7 @@ static int test_events(const struct evlist_test *events, int cnt)
>                 pr_debug("running test %d '%s'\n", i, e.name);
>                 test_ret = test_event(&e);
>                 if (test_ret != TEST_OK) {
> -                       pr_debug("Event test failure: test %d '%s'", i, e.name);
> +                       pr_debug("Event test failure: test %d '%s'\n", i, e.name);
>                         ret = combine_test_results(ret, test_ret);
>                 }
>         }
> @@ -2764,7 +2764,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>
>                         test_ret = test_event(&e);
>                         if (test_ret != TEST_OK) {
> -                               pr_debug("Test PMU event failed for '%s'", name);
> +                               pr_debug("Test PMU event failed for '%s'\n", name);
>                                 ret = combine_test_results(ret, test_ret);
>                         }
>
> @@ -2790,7 +2790,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>                         e.check = test__checkevent_pmu_events_mix;
>                         test_ret = test_event(&e);
>                         if (test_ret != TEST_OK) {
> -                               pr_debug("Test PMU event failed for '%s'", name);
> +                               pr_debug("Test PMU event failed for '%s'\n", name);
>                                 ret = combine_test_results(ret, test_ret);
>                         }
>                 }
>
> --
> 2.34.1
>