[PATCH 0/2] perf tools: Always uniquify event names

James Clark posted 2 patches 2 weeks, 1 day ago
tools/perf/tests/parse-events.c | 6 +++---
tools/perf/util/parse-events.c  | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
[PATCH 0/2] perf tools: Always uniquify event names
Posted by James Clark 2 weeks, 1 day ago
The commit where this test starts failing is commit 2e6dc3b9334c ("perf
test parse-events: Without a PMU use cpu-cycles rather than cycles"),
but that commit is only a test change, whereas this fix is a code
change. For that reason I didn't add a fixes tag because I don't think
it's worth the risk of backporting a potential behavioral change just to
fix a test.

I'm also fairly unconfident on what the impact of this change is, other
than there's no change to the test results apart from the mentioned
failure.

It also brings up the question whether we should be running the tests
in both verbose and non-verbose modes by default. With a non trivial
amount of behavior being affected by the flag it seems like it could
catch some issues. Although it would double the runtime, and not all of
the tests will ever be affected.

Signed-off-by: James Clark <james.clark@linaro.org>
---
James Clark (2):
      perf tools: Always uniquify event names
      perf test: Add missing newlines in debug messages

 tools/perf/tests/parse-events.c | 6 +++---
 tools/perf/util/parse-events.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 267c2e633af6e9461477bed91e428993f8b36ee8
change-id: 20251203-james-parse-events-test-b4c092807640

Best regards,
-- 
James Clark <james.clark@linaro.org>