Add support for Awinic AW86938 haptic driver

[PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support

Posted by Griffin Kroah-Hartman 2 weeks, 1 day ago

Add the required node for haptic playback (Awinic AW86938)

Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
---
 arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
index 0a758fb7f4d413a84cdae695c38616fc6075db67..8c43bc9c1d8312f22ad0aeed84b23d52910e0ca6 100644
--- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
+++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
@@ -717,6 +717,16 @@ vreg_l7p: ldo7 {
 
 	/* VL53L3 ToF @ 0x29 */
 	/* AW86938FCR vibrator @ 0x5a */
+	vibrator@5a {
+		compatible = "awinic,aw86938";
+		reg = <0x5a>;
+
+		interrupts-extended = <&tlmm 80 IRQ_TYPE_EDGE_FALLING>;
+		reset-gpios = <&tlmm 78 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&aw86938_int_default>;
+		pinctrl-names = "default";
+	};
 };
 
 &ipa {
@@ -907,6 +917,13 @@ sdc2_card_det_n: sdc2-card-det-state {
 		bias-pull-up;
 	};
 
+	aw86938_int_default: aw86938-int-default-state {
+		pins = "gpio80";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+
 	pm8008_int_default: pm8008-int-default-state {
 		pins = "gpio125";
 		function = "gpio";

-- 
2.43.0

Re: [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support

Posted by Konrad Dybcio 2 weeks, 1 day ago

On 12/4/25 1:29 PM, Griffin Kroah-Hartman wrote:
> Add the required node for haptic playback (Awinic AW86938)
> 
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++

The DTS is unfortunately still not merged :/

Please arrange with Luca and either squash this into the resubmission
(depending on how the driver changes go for the vibrator) or resend it
afterwards

>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> index 0a758fb7f4d413a84cdae695c38616fc6075db67..8c43bc9c1d8312f22ad0aeed84b23d52910e0ca6 100644
> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> @@ -717,6 +717,16 @@ vreg_l7p: ldo7 {
>  
>  	/* VL53L3 ToF @ 0x29 */
>  	/* AW86938FCR vibrator @ 0x5a */

You can remove this comment now

The remainder of the patch lgtm

Konrad

Re: [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support

Posted by David Heidelberg 2 weeks, 1 day ago

On 04/12/2025 14:34, Konrad Dybcio wrote:
> On 12/4/25 1:29 PM, Griffin Kroah-Hartman wrote:
>> Add the required node for haptic playback (Awinic AW86938)
>>
>> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
>> ---
>>   arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++
> 
> The DTS is unfortunately still not merged :/
> 
> Please arrange with Luca and either squash this into the resubmission
> (depending on how the driver changes go for the vibrator) or resend it
> afterwards

would be enough to provide dependency on the Luca patchset trough the 
amazing

b4 prep --edit-deps

here?

David

> 
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index 0a758fb7f4d413a84cdae695c38616fc6075db67..8c43bc9c1d8312f22ad0aeed84b23d52910e0ca6 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -717,6 +717,16 @@ vreg_l7p: ldo7 {
>>   
>>   	/* VL53L3 ToF @ 0x29 */
>>   	/* AW86938FCR vibrator @ 0x5a */
> 
> You can remove this comment now
> 
> The remainder of the patch lgtm
> 
> Konrad
> 

-- 
David Heidelberg

Re: [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support

Posted by Konrad Dybcio 2 weeks, 1 day ago

On 12/4/25 2:43 PM, David Heidelberg wrote:
> On 04/12/2025 14:34, Konrad Dybcio wrote:
>> On 12/4/25 1:29 PM, Griffin Kroah-Hartman wrote:
>>> Add the required node for haptic playback (Awinic AW86938)
>>>
>>> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++
>>
>> The DTS is unfortunately still not merged :/
>>
>> Please arrange with Luca and either squash this into the resubmission
>> (depending on how the driver changes go for the vibrator) or resend it
>> afterwards
> 
> would be enough to provide dependency on the Luca patchset trough the amazing
> 
> b4 prep --edit-deps
> 
> here?

This makes sense for patches that are predicted to be merged without
obstacles - IIRC Luca's original series still may have some dependencies
on various subsystem maintainers for oneliner compatibles

Konrad