[PATCH] Documentation: remoteproc: fix deadlink

Soham Metha posted 1 patch 2 weeks, 2 days ago
.../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Documentation: remoteproc: fix deadlink
Posted by Soham Metha 2 weeks, 2 days ago
The binding file 'gpio-dsp-keystone.txt' has been converted to a DT schema.
The current binding is located at:

    Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml

This change was made in https://lore.kernel.org/all/20250714202850.3011952-1-robh@kernel.org/
and merged in aff0a1701b020c8e6b172f28828fd4f3e6eed41a

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
index 463a97c11eff..91f0a3b0c0b2 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
+++ b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
@@ -66,7 +66,7 @@ The following are the mandatory properties:
 - kick-gpios: 		Should specify the gpio device needed for the virtio IPC
 			stack. This will be used to interrupt the remote processor.
 			The gpio device to be used is as per the bindings in,
-			Documentation/devicetree/bindings/gpio/gpio-dsp-keystone.txt
+			Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
 
 SoC-specific Required properties:
 ---------------------------------
-- 
2.34.1
Re: [PATCH] Documentation: remoteproc: fix deadlink
Posted by Krzysztof Kozlowski 2 weeks, 2 days ago
On 03/12/2025 18:07, Soham Metha wrote:
> The binding file 'gpio-dsp-keystone.txt' has been converted to a DT schema.
> The current binding is located at:
> 
>     Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
> 
> This change was made in https://lore.kernel.org/all/20250714202850.3011952-1-robh@kernel.org/
> and merged in aff0a1701b020c8e6b172f28828fd4f3e6eed41a

Drop this sentence and instead please use 'commit sha' syntax, see
checkpatch and submitting patches docs for details.

> 
> Signed-off-by: Soham Metha <sohammetha01@gmail.com>
> ---
>  .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-

Best regards,
Krzysztof
Re: [PATCH] Documentation: remoteproc: fix deadlink
Posted by Krzysztof Kozlowski 2 weeks, 2 days ago
On 03/12/2025 18:21, Krzysztof Kozlowski wrote:
> On 03/12/2025 18:07, Soham Metha wrote:
>> The binding file 'gpio-dsp-keystone.txt' has been converted to a DT schema.
>> The current binding is located at:
>>
>>     Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
>>
>> This change was made in https://lore.kernel.org/all/20250714202850.3011952-1-robh@kernel.org/
>> and merged in aff0a1701b020c8e6b172f28828fd4f3e6eed41a
> 
> Drop this sentence and instead please use 'commit sha' syntax, see
> checkpatch and submitting patches docs for details.
> 
>>
>> Signed-off-by: Soham Metha <sohammetha01@gmail.com>
>> ---
>>  .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-

And:

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


Best regards,
Krzysztof
Re: [PATCH] Documentation: remoteproc: fix deadlink
Posted by Soham Metha 2 weeks, 2 days ago
On 03/12/25 22:51, Krzysztof Kozlowski wrote:
> On 03/12/2025 18:21, Krzysztof Kozlowski wrote:
>> On 03/12/2025 18:07, Soham Metha wrote:
>>> The binding file 'gpio-dsp-keystone.txt' has been converted to a DT schema.
>>> The current binding is located at:
>>>
>>>     Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
>>>
>>> This change was made in https://lore.kernel.org/all/20250714202850.3011952-1-robh@kernel.org/
>>> and merged in aff0a1701b020c8e6b172f28828fd4f3e6eed41a
>>
>> Drop this sentence and instead please use 'commit sha' syntax, see
>> checkpatch and submitting patches docs for details.
>>
>>>
>>> Signed-off-by: Soham Metha <sohammetha01@gmail.com>
>>> ---
>>>  .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-
> 
> And:
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> 
> Best regards,
> Krzysztof


Thanks for the review.
I'll switch to the proper syntax and resend the patch.

--
Soham Metha