With W=1, the following error comes up:

Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property

This is because the child node being removed during flattening and moving
to latest bindings.

Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 2ca9e50ef599..e3f93f4f412d 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -4133,8 +4133,6 @@ usb_dp_qmpphy_dp_in: endpoint {
 		usb_1: usb@a600000 {
 			compatible = "qcom,sm8550-dwc3", "qcom,snps-dwc3";
 			reg = <0x0 0x0a600000 0x0 0xfc100>;
-			#address-cells = <1>;
-			#size-cells = <0>;
 
 			clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
 				 <&gcc GCC_USB30_PRIM_MASTER_CLK>,
-- 
2.34.1

On 03/12/2025 15:48, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> This is because the child node being removed during flattening and moving
> to latest bindings.
> 
> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")


I don't fully understand that original commit - it explicitly changed
address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
kind of intentional. Anyway, these should not be needed, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

On 12/3/25 16:07, Krzysztof Kozlowski wrote:
> On 03/12/2025 15:48, Krishna Kurapati wrote:
>> With W=1, the following error comes up:
>>
>> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>>
>> This is because the child node being removed during flattening and moving
>> to latest bindings.
>>
>> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
> 
> 
> I don't fully understand that original commit - it explicitly changed
> address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
> kind of intentional. Anyway, these should not be needed, so:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

They were kept to allow adding usb submodes representing usb devices,
as the bindings allows. It's not _needed_ until we add some subnodes.

Neil

> 
> Best regards,
> Krzysztof