cleanup.h coding style asks to avoid having constructors with redundant
values (= NULL). On purpose, because it is just not making the code
simpler. The constructor should be meaningful not just NULL.

If you do not agree in declaration-in-place-of-use (fair!), then do not
use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
before.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      ASoC: amd: acp-sdw-legacy: Fix confusing cleanup.h syntax
      ASoC: amd: acp-sdw-sof: Fix confusing cleanup.h syntax
      ASoC: SDCA: functions: Fix confusing cleanup.h syntax

 sound/soc/amd/acp/acp-sdw-legacy-mach.c |  8 ++++----
 sound/soc/amd/acp/acp-sdw-sof-mach.c    |  8 ++++----
 sound/soc/sdca/sdca_functions.c         | 28 ++++++++++++++--------------
 3 files changed, 22 insertions(+), 22 deletions(-)
---
base-commit: 32ed136b4e871f08398f342aa92feffed020839b
change-id: 20251203-asoc-wrong-cleanup-h-continued-6e3d27d097df

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

On Wed, 03 Dec 2025 17:12:37 +0100, Krzysztof Kozlowski wrote:
> cleanup.h coding style asks to avoid having constructors with redundant
> values (= NULL). On purpose, because it is just not making the code
> simpler. The constructor should be meaningful not just NULL.
> 
> If you do not agree in declaration-in-place-of-use (fair!), then do not
> use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
> before.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: amd: acp-sdw-legacy: Fix confusing cleanup.h syntax
      commit: 5a7e236925b417332a674a8488ef19da233a5764
[2/3] ASoC: amd: acp-sdw-sof: Fix confusing cleanup.h syntax
      commit: bafd5cf04b2822bf3c865add7262d86e22b9588e
[3/3] ASoC: SDCA: functions: Fix confusing cleanup.h syntax
      commit: e39011184f23de3d04ca8e80b4df76c9047b4026

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark