[PATCH v6 0/4] uacce: driver fixes for memory leaks and state management

Chenghai Huang posted 4 patches 2 months, 1 week ago
drivers/misc/uacce/uacce.c | 48 +++++++++++++++++++++++++++++++-------
1 file changed, 40 insertions(+), 8 deletions(-)
[PATCH v6 0/4] uacce: driver fixes for memory leaks and state management
Posted by Chenghai Huang 2 months, 1 week ago
This patch series addresses several issues in the uacce:
1.Fix cdev handling in the cleanup path.
2.Fix sysfs file creation conditions.
3.Add error reporting for unsupported mremap operations.
4.Ensuring safe queue release with proper state management.

---
Changes in v6:
- In patch 1, if cdev_device_add() fails, it will automatically free the cdev, however,
  we need to set uacce->cdev to NULL to prevent cdev_device_del() from being called.
- Link to v5: https://lore.kernel.org/all/20251111093536.3729-1-huangchenghai2@huawei.com/

Changes in v5:
- There is no memory leak issue when cdev_device_add fails, but it is necessary
  to check a flag to avoid calling cdev_device_del during abnormal exit.
- Link to v4: https://lore.kernel.org/all/20251022021149.1771168-1-huangchenghai2@huawei.com/

Changes in v4:
- Revert the interception of sysfs creation for isolate_strategy.
- Link to v3: https://lore.kernel.org/all/20251021135003.786588-1-huangchenghai2@huawei.com/

Changes in v3:
- Move the checks for the 'isolate_strategy_show' and
  'isolate_strategy_store' functions to their respective call sites.
- Use kobject_put to release the cdev memory instead of modifying
  cdev to be a static structure member.
- Link to v2: https://lore.kernel.org/all/20250916144811.1799687-1-huangchenghai2@huawei.com/

Changes in v2:
- Use cdev_init to allocate cdev memory to ensure that memory leaks
  are avoided.
- Supplement the reason for intercepting the remapping operation.
- Add "cc: stable@vger.kernel.org" to paths with fixed.
- Link to v1: https://lore.kernel.org/all/20250822103904.3776304-1-huangchenghai2@huawei.com/

Chenghai Huang (2):
  uacce: fix isolate sysfs check condition
  uacce: ensure safe queue release with state management

Wenkai Lin (1):
  uacce: fix cdev handling in the cleanup path

Yang Shen (1):
  uacce: implement mremap in uacce_vm_ops to return -EPERM

 drivers/misc/uacce/uacce.c | 48 +++++++++++++++++++++++++++++++-------
 1 file changed, 40 insertions(+), 8 deletions(-)

-- 
2.33.0
Re: [PATCH v6 0/4] uacce: driver fixes for memory leaks and state management
Posted by huangchenghai 1 month ago
Kindly ping for this fix.


Cheers,
Chenghai

在 2025/12/2 14:12, Chenghai Huang 写道:
> This patch series addresses several issues in the uacce:
> 1.Fix cdev handling in the cleanup path.
> 2.Fix sysfs file creation conditions.
> 3.Add error reporting for unsupported mremap operations.
> 4.Ensuring safe queue release with proper state management.
>
> ---
> Changes in v6:
> - In patch 1, if cdev_device_add() fails, it will automatically free the cdev, however,
>    we need to set uacce->cdev to NULL to prevent cdev_device_del() from being called.
> - Link to v5: https://lore.kernel.org/all/20251111093536.3729-1-huangchenghai2@huawei.com/
>
> Changes in v5:
> - There is no memory leak issue when cdev_device_add fails, but it is necessary
>    to check a flag to avoid calling cdev_device_del during abnormal exit.
> - Link to v4: https://lore.kernel.org/all/20251022021149.1771168-1-huangchenghai2@huawei.com/
>
> Changes in v4:
> - Revert the interception of sysfs creation for isolate_strategy.
> - Link to v3: https://lore.kernel.org/all/20251021135003.786588-1-huangchenghai2@huawei.com/
>
> Changes in v3:
> - Move the checks for the 'isolate_strategy_show' and
>    'isolate_strategy_store' functions to their respective call sites.
> - Use kobject_put to release the cdev memory instead of modifying
>    cdev to be a static structure member.
> - Link to v2: https://lore.kernel.org/all/20250916144811.1799687-1-huangchenghai2@huawei.com/
>
> Changes in v2:
> - Use cdev_init to allocate cdev memory to ensure that memory leaks
>    are avoided.
> - Supplement the reason for intercepting the remapping operation.
> - Add "cc: stable@vger.kernel.org" to paths with fixed.
> - Link to v1: https://lore.kernel.org/all/20250822103904.3776304-1-huangchenghai2@huawei.com/
>
> Chenghai Huang (2):
>    uacce: fix isolate sysfs check condition
>    uacce: ensure safe queue release with state management
>
> Wenkai Lin (1):
>    uacce: fix cdev handling in the cleanup path
>
> Yang Shen (1):
>    uacce: implement mremap in uacce_vm_ops to return -EPERM
>
>   drivers/misc/uacce/uacce.c | 48 +++++++++++++++++++++++++++++++-------
>   1 file changed, 40 insertions(+), 8 deletions(-)
>
Re: [PATCH v6 0/4] uacce: driver fixes for memory leaks and state management
Posted by Greg KH 3 weeks, 1 day ago
On Tue, Jan 06, 2026 at 10:38:46AM +0800, huangchenghai wrote:
> Kindly ping for this fix.
> 

Sorry for the delay, looks good, now queued up!

greg k-h