[PATCH] fat: remove unused parameter

Lalit Shankar Chowdhury posted 1 patch 2 months, 1 week ago
fs/fat/cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] fat: remove unused parameter
Posted by Lalit Shankar Chowdhury 2 months, 1 week ago
Remove unused inode parameter from fat_cache_alloc().

Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
 fs/fat/cache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fat/cache.c b/fs/fat/cache.c
index 2af424e200b3..4cea26ddc161 100644
--- a/fs/fat/cache.c
+++ b/fs/fat/cache.c
@@ -59,7 +59,7 @@ void fat_cache_destroy(void)
 	kmem_cache_destroy(fat_cache_cachep);
 }
 
-static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
+static inline struct fat_cache *fat_cache_alloc(void)
 {
 	return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
 }
@@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
 			MSDOS_I(inode)->nr_caches++;
 			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
 
-			tmp = fat_cache_alloc(inode);
+			tmp = fat_cache_alloc();
 			if (!tmp) {
 				spin_lock(&MSDOS_I(inode)->cache_lru_lock);
 				MSDOS_I(inode)->nr_caches--;
-- 
2.52.0
Re: [PATCH] fat: remove unused parameter
Posted by OGAWA Hirofumi 2 months, 1 week ago
Lalit Shankar Chowdhury <lalitshankarch@gmail.com> writes:

> Remove unused inode parameter from fat_cache_alloc().
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> ---
>  fs/fat/cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..4cea26ddc161 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -59,7 +59,7 @@ void fat_cache_destroy(void)
>  	kmem_cache_destroy(fat_cache_cachep);
>  }
>  
> -static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
> +static inline struct fat_cache *fat_cache_alloc(void)
>  {
>  	return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
>  }
> @@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
>  			MSDOS_I(inode)->nr_caches++;
>  			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
>  
> -			tmp = fat_cache_alloc(inode);
> +			tmp = fat_cache_alloc();
>  			if (!tmp) {
>  				spin_lock(&MSDOS_I(inode)->cache_lru_lock);
>  				MSDOS_I(inode)->nr_caches--;

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>