[PATCH v2 4/6] dmaengine: sh: rz_dmac: add RZ/{T2H,N2H} support

Cosmin Tanislav posted 6 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH v2 4/6] dmaengine: sh: rz_dmac: add RZ/{T2H,N2H} support
Posted by Cosmin Tanislav 2 months, 1 week ago
The Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs use a
completely different ICU unit compared to RZ/V2H, which requires a
separate implementation.

Add support for them.

RZ/N2H will use RZ/T2H as a fallback.

Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
---

V2:
 * remove notes

 drivers/dma/sh/rz-dmac.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
index f94be3f8e232..c0c23c39a626 100644
--- a/drivers/dma/sh/rz-dmac.c
+++ b/drivers/dma/sh/rz-dmac.c
@@ -15,6 +15,7 @@
 #include <linux/interrupt.h>
 #include <linux/iopoll.h>
 #include <linux/irqchip/irq-renesas-rzv2h.h>
+#include <linux/irqchip/irq-renesas-rzt2h.h>
 #include <linux/list.h>
 #include <linux/module.h>
 #include <linux/of.h>
@@ -1073,12 +1074,18 @@ static const struct rz_dmac_info rz_dmac_v2h_info = {
 	.dma_req_no_default = RZV2H_ICU_DMAC_REQ_NO_DEFAULT,
 };
 
+static const struct rz_dmac_info rz_dmac_t2h_info = {
+	.register_dma_req = rzt2h_icu_register_dma_req,
+	.dma_req_no_default = RZT2H_ICU_DMAC_REQ_NO_DEFAULT,
+};
+
 static const struct rz_dmac_info rz_dmac_common_info = {
 	.dma_req_no_default = 0,
 };
 
 static const struct of_device_id of_rz_dmac_match[] = {
 	{ .compatible = "renesas,r9a09g057-dmac", .data = &rz_dmac_v2h_info },
+	{ .compatible = "renesas,r9a09g077-dmac", .data = &rz_dmac_t2h_info },
 	{ .compatible = "renesas,rz-dmac", .data = &rz_dmac_common_info },
 	{ /* Sentinel */ }
 };
-- 
2.52.0
Re: [PATCH v2 4/6] dmaengine: sh: rz_dmac: add RZ/{T2H,N2H} support
Posted by Geert Uytterhoeven 1 month, 2 weeks ago
Hi Cosmin,

CC tglx

On Mon, 1 Dec 2025 at 13:50, Cosmin Tanislav
<cosmin-gabriel.tanislav.xa@renesas.com> wrote:
> The Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs use a
> completely different ICU unit compared to RZ/V2H, which requires a
> separate implementation.
>
> Add support for them.
>
> RZ/N2H will use RZ/T2H as a fallback.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>

Thanks for your patch!

> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -15,6 +15,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/irqchip/irq-renesas-rzv2h.h>
> +#include <linux/irqchip/irq-renesas-rzt2h.h>

As this has a hard dependency on commit 13e7b3305b647cf5 ("irqchip: Add
RZ/{T2H,N2H} Interrupt Controller (ICU) driver") in irqchip/irq/drivers
(next-20251217 and later), Vinod cannot apply this patch without
merging that dependency first.

>  #include <linux/list.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> @@ -1073,12 +1074,18 @@ static const struct rz_dmac_info rz_dmac_v2h_info = {
>         .dma_req_no_default = RZV2H_ICU_DMAC_REQ_NO_DEFAULT,
>  };
>
> +static const struct rz_dmac_info rz_dmac_t2h_info = {
> +       .register_dma_req = rzt2h_icu_register_dma_req,
> +       .dma_req_no_default = RZT2H_ICU_DMAC_REQ_NO_DEFAULT,
> +};
> +
>  static const struct rz_dmac_info rz_dmac_common_info = {
>         .dma_req_no_default = 0,
>  };
>
>  static const struct of_device_id of_rz_dmac_match[] = {
>         { .compatible = "renesas,r9a09g057-dmac", .data = &rz_dmac_v2h_info },
> +       { .compatible = "renesas,r9a09g077-dmac", .data = &rz_dmac_t2h_info },
>         { .compatible = "renesas,rz-dmac", .data = &rz_dmac_common_info },
>         { /* Sentinel */ }
>  };

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds