On 12/1/25 11:50, Philipp Stanner wrote:
> The return code of dma_fence_signal() is not really useful as there is
> nothing reasonable to do if a fence was already signaled. That return
> code shall be removed from the kernel.
>
> Moreover, dma_fence_signal() should not be used to check whether fences
> are signaled. That's what dma_fence_is_signaled() and
> dma_fence_test_signaled_flag() exist for.
>
> Replace the non-canonical usage of dma_fence_signal().
>
> Suggested-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/st-dma-fence.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index 27a36045410b..4dbe39c58bfb 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -126,7 +126,7 @@ static int test_signaling(void *arg)
> goto err_free;
> }
>
> - if (dma_fence_signal(f)) {
> + if (dma_fence_check_and_signal(f)) {
> pr_err("Fence reported being already signaled\n");
> goto err_free;
> }
> @@ -136,7 +136,7 @@ static int test_signaling(void *arg)
> goto err_free;
> }
>
> - if (!dma_fence_signal(f)) {
> + if (!dma_fence_test_signaled_flag(f)) {
> pr_err("Fence reported not being already signaled\n");
> goto err_free;
> }