[v2] arm64: dts/thermal: Add MT8189 thermal controller and driver support

[PATCH v2 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node

Posted by Hanchien Lin 2 months, 1 week ago

Add device tree node for the thermal controller on MediaTek MT8189 SoC.

Signed-off-by: Hanchien Lin <hanchien.lin@mediatek.com>
---
 .../thermal/mediatek,lvts-thermal.yaml        | 27 +++++++++++++++++--
 .../thermal/mediatek,lvts-thermal.h           | 20 ++++++++++++++
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
index 0259cd3ce9c5..0f7fd69f5fdf 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
@@ -22,6 +22,8 @@ properties:
       - mediatek,mt8186-lvts
       - mediatek,mt8188-lvts-ap
       - mediatek,mt8188-lvts-mcu
+      - mediatek,mt8189-lvts-ap
+      - mediatek,mt8189-lvts-mcu
       - mediatek,mt8192-lvts-ap
       - mediatek,mt8192-lvts-mcu
       - mediatek,mt8195-lvts-ap
@@ -58,6 +60,21 @@ properties:
 allOf:
   - $ref: thermal-sensor.yaml#
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt8189-lvts-ap
+              - mediatek,mt8189-lvts-mcu
+    then:
+      properties:
+        nvmem-cells:
+          minItems: 2
+
+        nvmem-cell-names:
+          minItems: 2
+
   - if:
       properties:
         compatible:
@@ -75,6 +92,10 @@ allOf:
         nvmem-cell-names:
           maxItems: 1
 
+      required:
+        - clocks
+        - resets
+
   - if:
       properties:
         compatible:
@@ -91,12 +112,14 @@ allOf:
         nvmem-cell-names:
           minItems: 2
 
+      required:
+        - clocks
+        - resets
+
 required:
   - compatible
   - reg
   - interrupts
-  - clocks
-  - resets
   - nvmem-cells
   - nvmem-cell-names
 
diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
index ddc7302a510a..6c9103dfdc2d 100644
--- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h
+++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
@@ -42,6 +42,26 @@
 #define MT8188_AP_CAM1		6
 #define MT8188_AP_CAM2		7
 
+#define MT8189_MCU_BIG_CPU1     0
+#define MT8189_MCU_BIG_CPU2     1
+#define MT8189_MCU_BIG_CPU3     2
+#define MT8189_MCU_BIG_CPU4     3
+#define MT8189_MCU_LITTLE_CPU1  4
+#define MT8189_MCU_LITTLE_CPU2  5
+#define MT8189_MCU_LITTLE_CPU3  6
+#define MT8189_MCU_LITTLE_CPU4  7
+#define MT8189_MCU_LITTLE_CPU5  8
+#define MT8189_MCU_LITTLE_CPU6  9
+#define MT8189_MCU_LITTLE_CPU7  10
+#define MT8189_MCU_LITTLE_CPU8  11
+
+#define MT8189_AP_SOC1          12
+#define MT8189_AP_SOC2          13
+#define MT8189_AP_SOC3          14
+#define MT8189_AP_APU           15
+#define MT8189_AP_GPU1          16
+#define MT8189_AP_GPU2          17
+
 #define MT8195_MCU_BIG_CPU0     0
 #define MT8195_MCU_BIG_CPU1     1
 #define MT8195_MCU_BIG_CPU2     2
-- 
2.45.2

Re: [PATCH v2 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node

Posted by Krzysztof Kozlowski 2 months, 1 week ago

On 01/12/2025 11:06, Hanchien Lin wrote:
> Add device tree node for the thermal controller on MediaTek MT8189 SoC.
> 
> Signed-off-by: Hanchien Lin <hanchien.lin@mediatek.com>

Nothing improved. You just completely ignored feedback expecting
reviewers to repeat themself.

NAK

Best regards,
Krzysztof

RE: [PATCH v2 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node

Posted by Hanchien Lin (林翰謙) 2 months ago

Hi Krzysztof,

Thank you for your feedback, and I apologize for missing your previous comments. I will carefully review all the feedback and make the necessary changes in the next version of the patch.

Sorry for the inconvenience caused.

Best regards,
Hanchien Lin.

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Monday, December 1, 2025 6:10 PM
To: Hanchien Lin (林翰謙) <Hanchien.Lin@mediatek.com>; Rafael J . Wysocki <rafael@kernel.org>; Daniel Lezcano <daniel.lezcano@linaro.org>; Zhang Rui <rui.zhang@intel.com>; Lukasz Luba <lukasz.luba@arm.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Philipp Zabel <p.zabel@pengutronix.de>; Matthias Brugger <matthias.bgg@gmail.com>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; Balsam CHIHI <bchihi@baylibre.com>
Cc: Irving-CH Lin (林建弘) <Irving-CH.Lin@mediatek.com>; Jh Hsu (許希孜) <Jh.Hsu@mediatek.com>; WH Wu (吳文宏) <vincent.wu@mediatek.com>; Raymond Sun (孫俊斌) <Raymond.Sun@mediatek.com>; Sirius Wang (王皓昱) <Sirius.Wang@mediatek.com>; linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node


External email : Please do not click links or open attachments until you have verified the sender or the content.


On 01/12/2025 11:06, Hanchien Lin wrote:
> Add device tree node for the thermal controller on MediaTek MT8189 SoC.
>
> Signed-off-by: Hanchien Lin <hanchien.lin@mediatek.com>


Nothing improved. You just completely ignored feedback expecting reviewers to repeat themself.

NAK

Best regards,
Krzysztof