ASoC: codecs: wcd93xx: fix OF node leaks on probe failure

[PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure

Johan Hovold posted 3 patches 11 hours ago

Download series mbox

sound/soc/codecs/wcd937x.c | 4 ++--
sound/soc/codecs/wcd938x.c | 3 +--
sound/soc/codecs/wcd939x.c | 3 +--
3 files changed, 4 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure

Posted by Johan Hovold 11 hours ago

The original wcd938x driver has a couple of OF node reference leaks
which have been reproduced in the two later added drivers.

Johan


Johan Hovold (3):
  ASoC: codecs: wcd937x: fix OF node leaks on probe failure
  ASoC: codecs: wcd938x: fix OF node leaks on probe failure
  ASoC: codecs: wcd939x: fix OF node leaks on probe failure

 sound/soc/codecs/wcd937x.c | 4 ++--
 sound/soc/codecs/wcd938x.c | 3 +--
 sound/soc/codecs/wcd939x.c | 3 +--
 3 files changed, 4 insertions(+), 6 deletions(-)

-- 
2.51.2

Re: [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure

Posted by Srinivas Kandagatla 8 hours ago


On 12/1/25 9:34 AM, Johan Hovold wrote:
> The original wcd938x driver has a couple of OF node reference leaks
> which have been reproduced in the two later added drivers.
> 
> Johan
> 

Thanks for the patches,

Yes, of_parse_phandle() already gets a node refcount, another refcount
is redundant and will leak.

LGTM

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

--srini>
> Johan Hovold (3):
>   ASoC: codecs: wcd937x: fix OF node leaks on probe failure
>   ASoC: codecs: wcd938x: fix OF node leaks on probe failure
>   ASoC: codecs: wcd939x: fix OF node leaks on probe failure
> 
>  sound/soc/codecs/wcd937x.c | 4 ++--
>  sound/soc/codecs/wcd938x.c | 3 +--
>  sound/soc/codecs/wcd939x.c | 3 +--
>  3 files changed, 4 insertions(+), 6 deletions(-)
>