Add a custom handle_irq() for 8250_mxpcie based on serial8250_handle_irq(),
removing PM wakeup and DMA handling that are not needed.

This prepares for future adjustments to RX and TX behavior specific to
Moxa MUEx50 UART.

Signed-off-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
---
 drivers/tty/serial/8250/8250_mxpcie.c | 36 +++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_mxpcie.c b/drivers/tty/serial/8250/8250_mxpcie.c
index ceef6a5e677e..fe2906d16d80 100644
--- a/drivers/tty/serial/8250/8250_mxpcie.c
+++ b/drivers/tty/serial/8250/8250_mxpcie.c
@@ -253,6 +253,41 @@ static void mxpcie8250_unthrottle(struct uart_port *port)
 	uart_port_unlock_irqrestore(port, flags);
 }
 
+static int mxpcie8250_handle_irq(struct uart_port *port)
+{
+	struct uart_8250_port *up = up_to_u8250p(port);
+	bool skip_rx = false;
+	unsigned long flags;
+	u16 lsr;
+	u8 iir;
+
+	iir = serial_in(up, UART_IIR);
+
+	if (iir & UART_IIR_NO_INT)
+		return 0;
+
+	uart_port_lock_irqsave(port, &flags);
+
+	lsr = serial_lsr_in(up);
+
+	if (!(lsr & (UART_LSR_FIFOE | UART_LSR_BRK_ERROR_BITS)) &&
+	    (port->status & (UPSTAT_AUTOCTS | UPSTAT_AUTORTS)) &&
+	    !(port->read_status_mask & UART_LSR_DR))
+		skip_rx = true;
+
+	if (lsr & (UART_LSR_DR | UART_LSR_BI) && !skip_rx)
+		lsr = serial8250_rx_chars(up, lsr);
+
+	serial8250_modem_status(up);
+
+	if ((lsr & UART_LSR_THRE) && (up->ier & UART_IER_THRI))
+		serial8250_tx_chars(up);
+
+	uart_unlock_and_check_sysrq_irqrestore(port, flags);
+
+	return 1;
+}
+
 static int mxpcie8250_init(struct pci_dev *pdev)
 {
 	resource_size_t iobar_addr = pci_resource_start(pdev, 2);
@@ -344,6 +379,7 @@ static int mxpcie8250_probe(struct pci_dev *pdev, const struct pci_device_id *id
 	up.port.shutdown = mxpcie8250_shutdown;
 	up.port.throttle = mxpcie8250_throttle;
 	up.port.unthrottle = mxpcie8250_unthrottle;
+	up.port.handle_irq = mxpcie8250_handle_irq;
 
 	for (i = 0; i < num_ports; i++) {
 		if (mxpcie8250_setup(pdev, priv, &up, i))
-- 
2.45.2

On Sun, Nov 30, 2025 at 12:44 PM Crescent Hsieh
<crescentcy.hsieh@moxa.com> wrote:
>
> Add a custom handle_irq() for 8250_mxpcie based on serial8250_handle_irq(),
> removing PM wakeup and DMA handling that are not needed.
>
> This prepares for future adjustments to RX and TX behavior specific to
> Moxa MUEx50 UART.

...

> +static int mxpcie8250_handle_irq(struct uart_port *port)
> +{
> +       struct uart_8250_port *up = up_to_u8250p(port);
> +       bool skip_rx = false;
> +       unsigned long flags;
> +       u16 lsr;
> +       u8 iir;
> +
> +       iir = serial_in(up, UART_IIR);

> +

Unneeded blank line.

> +       if (iir & UART_IIR_NO_INT)
> +               return 0;
> +
> +       uart_port_lock_irqsave(port, &flags);
> +
> +       lsr = serial_lsr_in(up);

> +

Ditto.

> +       if (!(lsr & (UART_LSR_FIFOE | UART_LSR_BRK_ERROR_BITS)) &&
> +           (port->status & (UPSTAT_AUTOCTS | UPSTAT_AUTORTS)) &&
> +           !(port->read_status_mask & UART_LSR_DR))
> +               skip_rx = true;
> +
> +       if (lsr & (UART_LSR_DR | UART_LSR_BI) && !skip_rx)
> +               lsr = serial8250_rx_chars(up, lsr);

Again, perhaps it's better to split the above to a few if-return
conditionals in a local helper.

> +       serial8250_modem_status(up);
> +
> +       if ((lsr & UART_LSR_THRE) && (up->ier & UART_IER_THRI))
> +               serial8250_tx_chars(up);
> +
> +       uart_unlock_and_check_sysrq_irqrestore(port, flags);
> +
> +       return 1;
> +}


-- 
With Best Regards,
Andy Shevchenko