There is already a typedef for GPR callback used in 'struct
pkt_router_svc', so use it also in 'struct apr_driver', because it is
the same type - one is assigned to another in apr_device_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 include/linux/soc/qcom/apr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h
index 35f44cd868cb..b16530f319ad 100644
--- a/include/linux/soc/qcom/apr.h
+++ b/include/linux/soc/qcom/apr.h
@@ -156,7 +156,7 @@ struct apr_driver {
 	void	(*remove)(struct apr_device *sl);
 	int	(*callback)(struct apr_device *a,
 			    const struct apr_resp_pkt *d);
-	int	(*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op);
+	gpr_port_cb gpr_callback;
 	struct device_driver		driver;
 	const struct apr_device_id	*id_table;
 };

-- 
2.48.1

On Sun, Nov 30, 2025 at 10:40:24AM +0100, Krzysztof Kozlowski wrote:
> There is already a typedef for GPR callback used in 'struct
> pkt_router_svc', so use it also in 'struct apr_driver', because it is
> the same type - one is assigned to another in apr_device_probe().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Acked-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  include/linux/soc/qcom/apr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h
> index 35f44cd868cb..b16530f319ad 100644
> --- a/include/linux/soc/qcom/apr.h
> +++ b/include/linux/soc/qcom/apr.h
> @@ -156,7 +156,7 @@ struct apr_driver {
>  	void	(*remove)(struct apr_device *sl);
>  	int	(*callback)(struct apr_device *a,
>  			    const struct apr_resp_pkt *d);
> -	int	(*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op);
> +	gpr_port_cb gpr_callback;
>  	struct device_driver		driver;
>  	const struct apr_device_id	*id_table;
>  };
> 
> -- 
> 2.48.1
>