[PATCH] rust: auxiliary: use `pin_init::zeroed()` for ACPI device ID

Atharv Dubey posted 1 patch 2 days, 9 hours ago
rust/kernel/auxiliary.rs | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[PATCH] rust: auxiliary: use `pin_init::zeroed()` for ACPI device ID
Posted by Atharv Dubey 2 days, 9 hours ago
Replace the previous `unsafe { core::mem::zeroed() }` initialization
for `bindings::acpi_device_id` with `pin_init::zeroed()`. This removes
the explicit unsafe block and uses the safer pinned zero-initialization
helper.

Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
---
 rust/kernel/auxiliary.rs | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
index 7a3b0b9c418e..67c5d356d754 100644
--- a/rust/kernel/auxiliary.rs
+++ b/rust/kernel/auxiliary.rs
@@ -108,11 +108,7 @@ pub const fn new(modname: &'static CStr, name: &'static CStr) -> Self {
         let name = name.to_bytes_with_nul();
         let modname = modname.to_bytes_with_nul();
 
-        // TODO: Replace with `bindings::auxiliary_device_id::default()` once stabilized for
-        // `const`.
-        //
-        // SAFETY: FFI type is valid to be zero-initialized.
-        let mut id: bindings::auxiliary_device_id = unsafe { core::mem::zeroed() };
+        let mut id: bindings::auxiliary_device_id = pin_init::zeroed();
 
         let mut i = 0;
         while i < modname.len() {
-- 
2.43.0
Re: [PATCH] rust: auxiliary: use `pin_init::zeroed()` for ACPI device ID
Posted by Alexandre Courbot 18 hours ago
On Sat Nov 29, 2025 at 9:43 PM JST, Atharv Dubey wrote:
> Replace the previous `unsafe { core::mem::zeroed() }` initialization
> for `bindings::acpi_device_id` with `pin_init::zeroed()`. This removes
> the explicit unsafe block and uses the safer pinned zero-initialization
> helper.
>
> Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
> ---
>  rust/kernel/auxiliary.rs | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
> index 7a3b0b9c418e..67c5d356d754 100644
> --- a/rust/kernel/auxiliary.rs
> +++ b/rust/kernel/auxiliary.rs
> @@ -108,11 +108,7 @@ pub const fn new(modname: &'static CStr, name: &'static CStr) -> Self {
>          let name = name.to_bytes_with_nul();
>          let modname = modname.to_bytes_with_nul();
>  
> -        // TODO: Replace with `bindings::auxiliary_device_id::default()` once stabilized for
> -        // `const`.

Same as the other patch, I don't think this change obsoletes this TODO.