crypto: iaa - Remove unreachable pr_debug from iaa_crypto_cleanup_module

[PATCH] crypto: iaa - Remove unreachable pr_debug from iaa_crypto_cleanup_module

Posted by Thorsten Blum 3 days, 7 hours ago

iaa_unregister_compression_device() always returns 0, making the debug
log message unreachable. Remove the log statement and convert
iaa_unregister_compression_device() to a void function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/crypto/intel/iaa/iaa_crypto_main.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
index a91d8cb83d57..83d0ff1fc7c7 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
@@ -1698,12 +1698,10 @@ static int iaa_register_compression_device(void)
 	return ret;
 }
 
-static int iaa_unregister_compression_device(void)
+static void iaa_unregister_compression_device(void)
 {
 	if (iaa_crypto_registered)
 		crypto_unregister_acomp(&iaa_acomp_fixed_deflate);
-
-	return 0;
 }
 
 static int iaa_crypto_probe(struct idxd_dev *idxd_dev)
@@ -1919,8 +1917,7 @@ static int __init iaa_crypto_init_module(void)
 
 static void __exit iaa_crypto_cleanup_module(void)
 {
-	if (iaa_unregister_compression_device())
-		pr_debug("IAA compression device unregister failed\n");
+	iaa_unregister_compression_device();
 
 	iaa_crypto_debugfs_cleanup();
 	driver_remove_file(&iaa_crypto_driver.drv,
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4

RE: [PATCH] crypto: iaa - Remove unreachable pr_debug from iaa_crypto_cleanup_module

Posted by Sridhar, Kanchana P 4 hours ago

> -----Original Message-----
> From: Thorsten Blum <thorsten.blum@linux.dev>
> Sent: Friday, November 28, 2025 5:54 AM
> To: Accardi, Kristen C <kristen.c.accardi@intel.com>; Gomes, Vinicius
> <vinicius.gomes@intel.com>; Sridhar, Kanchana P
> <kanchana.p.sridhar@intel.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; David S. Miller <davem@davemloft.net>
> Cc: Thorsten Blum <thorsten.blum@linux.dev>; linux-crypto@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] crypto: iaa - Remove unreachable pr_debug from
> iaa_crypto_cleanup_module
> 
> iaa_unregister_compression_device() always returns 0, making the debug
> log message unreachable. Remove the log statement and convert
> iaa_unregister_compression_device() to a void function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Acked-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>


> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index a91d8cb83d57..83d0ff1fc7c7 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -1698,12 +1698,10 @@ static int iaa_register_compression_device(void)
>  	return ret;
>  }
> 
> -static int iaa_unregister_compression_device(void)
> +static void iaa_unregister_compression_device(void)
>  {
>  	if (iaa_crypto_registered)
>  		crypto_unregister_acomp(&iaa_acomp_fixed_deflate);
> -
> -	return 0;
>  }
> 
>  static int iaa_crypto_probe(struct idxd_dev *idxd_dev)
> @@ -1919,8 +1917,7 @@ static int __init iaa_crypto_init_module(void)
> 
>  static void __exit iaa_crypto_cleanup_module(void)
>  {
> -	if (iaa_unregister_compression_device())
> -		pr_debug("IAA compression device unregister failed\n");
> +	iaa_unregister_compression_device();
> 
>  	iaa_crypto_debugfs_cleanup();
>  	driver_remove_file(&iaa_crypto_driver.drv,
> --
> Thorsten Blum <thorsten.blum@linux.dev>
> GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4