hid: intel-thc-hid: Select SGL_ALLOC

[PATCH] hid: intel-thc-hid: Select SGL_ALLOC

Posted by Tim Zimmermann 2 months, 1 week ago

intel-thc-dma.c uses sgl_alloc() resulting in a build failure if CONFIG_SGL_ALLOC is not enabled

Signed-off-by: Tim Zimmermann <tim@linux4.de>
---
 drivers/hid/intel-thc-hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
index 0351d1137607..9d74e53b8c62 100644
--- a/drivers/hid/intel-thc-hid/Kconfig
+++ b/drivers/hid/intel-thc-hid/Kconfig
@@ -7,6 +7,7 @@ menu "Intel THC HID Support"
 config INTEL_THC_HID
 	tristate "Intel Touch Host Controller"
 	depends on ACPI
+	select SGL_ALLOC
 	help
 	  THC (Touch Host Controller) is the name of the IP block in PCH that
 	  interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It
-- 
2.51.0

Re: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC

Posted by Benjamin Tissoires 1 month ago

On Fri, 28 Nov 2025 08:54:22 +0100, Tim Zimmermann wrote:
> intel-thc-dma.c uses sgl_alloc() resulting in a build failure if CONFIG_SGL_ALLOC is not enabled
> 
> 

Applied to hid/hid.git (for-6.19/upstream-fixes), thanks!

[1/1] hid: intel-thc-hid: Select SGL_ALLOC
      https://git.kernel.org/hid/hid/c/dd76788f9ec4

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>

RE: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC

Posted by Even Xu 1 month, 2 weeks ago

From: "Xu, Even" <even.xu@intel.com>

> From: Tim Zimmermann <tim@linux4.de>
> Cc: tim@linux4.de, Even Xu <even.xu@intel.com>,
> 	Xinpeng Sun <xinpeng.sun@intel.com>,
> 	Jiri Kosina <jikos@kernel.org>,
> 	Benjamin Tissoires <bentiss@kernel.org>,
> 	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
> Subject: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC
> Date: Fri, 28 Nov 2025 08:54:22 +0100	[thread overview]
> Message-ID: <20251128075426.628500-1-tim@linux4.de> (raw)
> 
> intel-thc-dma.c uses sgl_alloc() resulting in a build failure if CONFIG_SGL_ALLOC is not enabled
> 
> Signed-off-by: Tim Zimmermann <tim@linux4.de>
> ---
>  drivers/hid/intel-thc-hid/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
> index 0351d1137607..9d74e53b8c62 100644
> --- a/drivers/hid/intel-thc-hid/Kconfig
> +++ b/drivers/hid/intel-thc-hid/Kconfig
> @@ -7,6 +7,7 @@ menu "Intel THC HID Support"
>  config INTEL_THC_HID
>  	tristate "Intel Touch Host Controller"
>  	depends on ACPI
> +	select SGL_ALLOC
>  	help
>  	  THC (Touch Host Controller) is the name of the IP block in PCH that
>  	  interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It

Thanks for the patch!

Reviewed-by: Even Xu <even.xu@intel.com>

> -- 
> 2.51.0